Conversation
|
Can one of the admins verify this patch? |
|
@kameshsampath I've added a Strimzi add-on, might be handy w/ your recent work..... |
add-ons/strimzi/strimzi.addon
Outdated
| oc apply -f strimzi-#{STRIMZI_VERSION}/examples/templates/cluster-operator -n #{PROJECT} | ||
|
|
||
| echo Waiting for Strimzi Cluster Operator to become ready | ||
| sleep 5; while echo && oc get pods -n myproject | grep -v -E "(Running|Completed|STATUS)"; do sleep 5; done |
|
@gbraad ah, yeah - sorry. that was an accident - pushed to early :-( |
|
Updated using the latest version of Strimzi. @kameshsampath @gbraad any comments? |
2 similar comments
|
Updated using the latest version of Strimzi. @kameshsampath @gbraad any comments? |
|
Updated using the latest version of Strimzi. @kameshsampath @gbraad any comments? |
|
updated to 0.8.1 of Strimzi |
|
looks good to me, its better to release for latest version when releasing first version of addon |
|
this is latest version
On Mon 22. Oct 2018 at 10:42, Kamesh Sampath ***@***.***> wrote:
looks good to me, its better to release for latest version when releasing
first version of addon
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#164 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJnznMkVJIlJl4Z72GonLOvAJan1OS1ks5unYTXgaJpZM4XAg7J>
.
--
Sent from Gmail Mobile
|
|
I know thats why I voted for it :) |
|
@gbraad I've addressed your original concerns - and it's now pointing to the latest |
|
@praveenkumar @gbraad updated w/ version requirements and also added a simple test |
| * [Installed](https://docs.okd.io/latest/minishift/command-ref/minishift_oc-env.html) OpenShift CLI | ||
|
|
||
| ## Start Minishift | ||
| The deployment works with Minishift default resources - 2 CPUs and 4 GB RAM. |
|
add to whitelist. |
|
@matzew can you please squash the commit into single one (I can see 5 commits associated to this PR)? |
|
@praveenkumar I've squashed to be one commit - sorry for the noise ! |
| # Description: Deploys an Apache Kafka Cluster | ||
| # Required-Vars: STRIMZI_VERSION | ||
| # Var-Defaults: STRIMZI_VERSION=#{STRIMZI_VERSION},PROJECT=strimzi | ||
| # OpenShift-Version: >=3.10.0 |
|
@gbraad can you take a look and if seem alright then let's merge it. |
|
@gbraad / @praveenkumar any comments on this ? |
|
retest this please |
|
@gbraad ping, I already approved it long back. |
| # Name: strimzi | ||
| # Description: Deploys an Apache Kafka Cluster | ||
| # Required-Vars: STRIMZI_VERSION | ||
| # Var-Defaults: STRIMZI_VERSION=#{STRIMZI_VERSION},PROJECT=myproject |
There was a problem hiding this comment.
You have to provide a default version in the Var-Defaults, the idea is that the users do not have to pass in a version if they want to stay with the default one, otherwise if you want the user to every time pass in the version than remove STRIMZI_VERSION from Var-Defaults
|
Apart from the |
|
+1 OK.
Waiting for the final changes
…On Mon, Feb 11, 2019 at 5:43 PM Anjan Nath ***@***.***> wrote:
Apart from the Var-Defaults change request, the add-on is working fine, all the deployments/operators are running
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
6 participants
For #163 I've added a Strimzi add-on!