Merged
Conversation
- Remove DotNetEnv package dependency and development.local.env file
- Move configuration to appsettings.json with environment variable overrides
- Consolidate logging setup with UseDmsSerilog() extension method
- Create AddDmsCoreWorkerService() bundle for common worker service configuration
- Simplify RabbitMQ configuration to use connection strings only
- Remove ConnectionStrings wrapper class in favor of standard GetConnectionString()
- Standardize Serilog file paths to use Path.Combine for cross-platform compatibility
- Add try/catch/finally error handling to Meow Program.cs
- Clean up redundant configuration registrations across all projects
samgibsonmoj
force-pushed
the
feature/remove-env-file
branch
from
2a268e2 to
abd019c
Compare
PaulCooperWorkJustice
approved these changes
Dec 1, 2025
PaulCooperWorkJustice
left a comment
PaulCooperWorkJustice
left a comment
There was a problem hiding this comment.
Changes look good and complete
ryankearsley-moj
pushed a commit
that referenced
this pull request
Dec 5, 2025
* Refactor: migrate from .env file to standard .NET configuration
- Remove DotNetEnv package dependency and development.local.env file
- Move configuration to appsettings.json with environment variable overrides
- Consolidate logging setup with UseDmsSerilog() extension method
- Create AddDmsCoreWorkerService() bundle for common worker service configuration
- Simplify RabbitMQ configuration to use connection strings only
- Remove ConnectionStrings wrapper class in favor of standard GetConnectionString()
- Standardize Serilog file paths to use Path.Combine for cross-platform compatibility
- Add try/catch/finally error handling to Meow Program.cs
- Clean up redundant configuration registrations across all projects
* Cleanup connection string usage and remove unused files
* Add placeholders for required ConnectionStrings
* Remove unused launchSettings for non ASP.NET apps
* Remove unused docker configurations
* Include RabbitMQ clarification for Meow
* Cleanup project references
* Make Aspire service naming consistent
* Remove .env file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5, #45 and #46.
This pull request makes several changes focused on cleaning up configuration management, improving logging setup, and refactoring the Blocking service for better maintainability and clarity. The most notable updates include removing obsolete configuration files and related code, refactoring the Blocking service's configuration classes, and enhancing logging for the API service.
Configuration and Environment Management:
development.local.envfile and all related references fromDirectory.Build.propsand the solution file, centralizing configuration management and eliminating reliance on local environment files.DotNetEnvpackage from dependencies, as environment variable loading from.envfiles is no longer required.Blocking Service Refactoring:
Blocking/ConfigurationModelsfolder, includingBlockingConfigurationDefaults,BlockingField,BlockingFieldGroup,BlockingFieldsConfig,CleaningConfig,DatabaseTable,TCleaningType,TFieldType, andTableField, simplifying the codebase and reducing confusion.DatabaseInsertclass in the Blocking service to use dependency injection for configuration and options, improving testability and maintainability. [1] [2]Blocking.csprojfile by removing Docker settings and references to Python interop files, reflecting the current architecture and dependencies.Logging Improvements:
API.csprojand enhanced the logging configuration inappsettings.jsonfor more robust and structured logging, including improved file paths and enrichment options. [1] [2]General Clean-up and Naming Consistency:
"api"→"Api","visualiser"→"Visualiser"). [1] [2]These changes collectively improve configuration management, code clarity, and logging, while removing legacy and unused components to streamline future development.