Skip to content

⏲️ Add sessions_opts#52

Merged
Jacob Woffenden (jacobwoffenden) merged 11 commits intomainfrom
chore/add-refresh-session-interval
Mar 19, 2025
Merged

⏲️ Add sessions_opts#52
Jacob Woffenden (jacobwoffenden) merged 11 commits intomainfrom
chore/add-refresh-session-interval

Conversation

@jacobwoffenden
Copy link
Copy Markdown
Member

@jacobwoffenden Jacob Woffenden (jacobwoffenden) commented Mar 11, 2025 •
edited
Loading

Part of ministryofjustice/analytical-platform#5242 (comment)

Proposed Changes

  • Skips CVEs
  • Adds session_opts
    • idling_timeout

      • Idling timeout specifies how long the session can be inactive until it is considered invalid, e.g. 900 (15 minutes) (in seconds), 0 disables the checks and touching.

    • rolling_timeout

      • Rolling timeout specifies how long the session can be used until it needs to be renewed, e.g. 3600 (an hour) (in seconds), 0 disables the checks and rolling.

Notes

Signed-off-by: Jacob Woffenden jacob.woffenden@justice.gov.uk

@jacobwoffenden
Add refresh_session_interval
bab3be8 
Signed-off-by: Jacob Woffenden <jacob.woffenden@justice.gov.uk>
@jacobwoffenden
Skip CVE-2024-56171 CVE-2025-24928
728bdc6 
Signed-off-by: Jacob Woffenden <jacob.woffenden@justice.gov.uk>
@jacobwoffenden
Add access_token_expires_in
40d5ea6
@jacobwoffenden
Fix missing comma!
e87e81b
@jacobwoffenden Jacob Woffenden (jacobwoffenden) changed the title ⏲️ Set refresh_session_interval to 8 hours ⏲️ Extend Lua configuration Mar 11, 2025
@jacobwoffenden Jacob Woffenden (jacobwoffenden) marked this pull request as draft March 11, 2025 17:17
@jacobwoffenden
Changes
f38eeb5 
Signed-off-by: Jacob Woffenden <jacob.woffenden@justice.gov.uk>
@jacobwoffenden
Add comma
2022f0f 
Signed-off-by: Jacob Woffenden <jacob.woffenden@justice.gov.uk>
@jacobwoffenden
Skip CVE-2025-0840 CVE-2025-27113
47ddb45 
Signed-off-by: Jacob Woffenden <jacob.woffenden@justice.gov.uk>
@jacobwoffenden
Add session_opts
dbf8c1a 
Signed-off-by: Jacob Woffenden <jacob.woffenden@justice.gov.uk>
@jamesstottmoj
Updated session_opts to not check for idling or rolling timeout
22c8b21
@jamesstottmoj
Update auth0-login.lua
23a43c4 
removed refresh_session_interval
@jacobwoffenden
Skip CVE-2024-8176, CVE-2024-55549 and CVE-2025-24855
9c78ac1
@jacobwoffenden Jacob Woffenden (jacobwoffenden) marked this pull request as ready for review March 18, 2025 07:26
@jacobwoffenden Jacob Woffenden (jacobwoffenden) changed the title ⏲️ Extend Lua configuration ⏲️ Add sessions_opts Mar 18, 2025
michaeljcollinsuk
Michael Collins (michaeljcollinsuk) approved these changes Mar 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaeljcollinsuk Michael Collins (michaeljcollinsuk) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden Jacob Woffenden (jacobwoffenden) merged commit 8d56ecd into main Mar 19, 2025
28 checks passed
@jacobwoffenden Jacob Woffenden (jacobwoffenden) deleted the chore/add-refresh-session-interval branch March 19, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaeljcollinsuk Michael Collins (michaeljcollinsuk) michaeljcollinsuk approved these changes

Assignees

@jacobwoffenden Jacob Woffenden (jacobwoffenden)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobwoffenden @michaeljcollinsuk @jamesstottmoj