Use new placeholder references in commands to cut down on sequential AAP-API calls#380
Open
Thomas-Geraghty wants to merge 10 commits intomainfrom
Open
Use new placeholder references in commands to cut down on sequential AAP-API calls#380Thomas-Geraghty wants to merge 10 commits intomainfrom
Thomas-Geraghty wants to merge 10 commits intomainfrom
Conversation
Playwright Test Results415 tests ±0 412 ✅ +1 48m 47s ⏱️ +47s For more details on these failures, see this check. Results for commit 3b8dcc5. ± Comparison against base commit dcfa932. ♻️ This comment has been updated with latest results. |
| }) | ||
|
|
||
| const results = await deps.api.executeCommands(...commands) | ||
| const addResult = results[commands.length - 1] as AddCollectionItemCommandResult |
Contributor
There was a problem hiding this comment.
Is it worth using a type guard here the same way you do in the AssessmentBuilder test?
Contributor
Author
There was a problem hiding this comment.
Ended up removing this!
…' into use-placeholder-refs-in-commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AAP-API recently got the ability to do placeholders/references for commands so that you can build items in collections in the same command that creates the collection, vastly cutting down on the amount of API calls that need to be made. Should improve performance a little 😄