Draft
Conversation
Thomas-Geraghty
had a problem deploying
to
test
GitHub Actions
Failure
* Add AAP API config and client * Add AAP API wiremock * Update strategies to use AAP_PLAN * LINT * Add support for the `previousOasysSanPk` and `previousOasysSpPk`, rework create to handle this * Add `newPeriodOfSupervision` parameter for marking if a plan needs resetting * Add `subjectDetails` and logging off `CRN` and `NOMIS_ID` in AAP_PLAN * Add `UPW` and `PSR_OUTLINE` plan types (no idea what to do with these yet?) * Wrap command requests/responses correctly for AAP * Fix test * Include the `null` condition in the `when` clause * Add support for legacy versioning of AAP Sentence Plans (#175) * Add support for legacy versioning of AAP Sentence Plans * Add test coverage for AAP plan strategy * Use Postgres for tests H2 doesn't support all Postgres features/datatypes we use, we should probably test against the same DB we intend to use in prod * Add coverage for AAP plan sign strategy * Add coverage for AAP plan lock strategy * Add coverage for AAP plan countersign strategy * Add coverage for OAsys version service * Add coverage for AAP plan fetch versions strategy * Refactor and tidy up * Update versioning strategy for AAP plans (#177) * Update versioning strategy for AAP plans * Remove unused enum --------- Co-authored-by: Lucas Cairns <lucas.cairns@gmail.com>
Thomas-Geraghty
force-pushed
the
national-rollout
branch
from
09b9a43 to
b77d33e
Compare
…PA entities, dont silently eat errors
* SP2-1931: Implement AAPPlanStretegy.reset() to call new API endpoint * SP2-1931: Store subject forename on assessment during plan creation * SP2-1931: Revert storing forename on assessment * SP2-1931: Adding success/failure tests * SP2-1931: Allow plan reset on same PK for new period of supervision * SP2-1931: Create OASys version on plan reset and return correct version in response * SP2-1931: Address review feedback on reset versioning * SP2-1931 add reset logic * SP2-1931: Remove obsolete same-PK conflict tests after create() refactor * SP2-1931: Restore oasysAssessmentPk uniqueness guard in create() * SP2-1931: Restore oasysAssessmentPk uniqueness guard in create() --------- Co-authored-by: devkokov <dm.kokov@gmail.com>
Nicola Ward (NicolaWard-SBG)
temporarily deployed
to
dev
GitHub Actions
Inactive
* Add plan versioning resolution to existing associations endpoint * Fix lint * Fix failing tests
Nicola Ward (NicolaWard-SBG)
temporarily deployed
to
test
GitHub Actions
Inactive
* Add endpoint to migrate associations * Fix typo * Refactor to use entity UUID over assessment PK
* Pin auth to a working version * try an older image --------- Co-authored-by: Lucas Cairns <lucas.cairns@gmail.com>
…N answers (#207) * SP2-2002: Clone SAN assessment when linking existing entity during create * SP2-2002: Add and adjust tests
Nicola Ward (NicolaWard-SBG)
temporarily deployed
to
test
GitHub Actions
Inactive
Nicola Ward (NicolaWard-SBG)
temporarily deployed
to
test
GitHub Actions
Inactive
* Update migrate endpoint to return 404 when no association found * Fix lint
Dimitar Kokov (devkokov)
temporarily deployed
to
dev
GitHub Actions
Inactive
Dimitar Kokov (devkokov)
temporarily deployed
to
test
GitHub Actions
Inactive
Dimitar Kokov (devkokov)
temporarily deployed
to
test
GitHub Actions
Inactive
Dimitar Kokov (devkokov)
temporarily deployed
to
dev
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch for national rollout, keep up to date with main