OV-449 audit update of visit comments changes.#146
Merged
Matt Crowson (matt-crowson-moj) merged 1 commit intomainfrom Mar 19, 2026
Merged
OV-449 audit update of visit comments changes.#146Matt Crowson (matt-crowson-moj) merged 1 commit intomainfrom
Matt Crowson (matt-crowson-moj) merged 1 commit intomainfrom
Conversation
Matt Crowson (matt-crowson-moj)
force-pushed
the
task/OV-449-audit-visit-changes-p2
branch
2 times, most recently
from
c0fb513 to
36b8401
Compare
Matt Crowson (matt-crowson-moj)
force-pushed
the
task/OV-449-audit-visit-changes-p2
branch
from
36b8401 to
0bd42fd
Compare
| } | ||
|
|
||
| override fun detailsText(): String = run { | ||
| if (changes.changes().isEmpty()) return@run "No recorded changes." |
Contributor
Author
There was a problem hiding this comment.
Is this even a thing? Should we record an audit change event if there is no actual change?
Contributor
There was a problem hiding this comment.
Probably? They submitted it..
Prabash Balasuriya (prabash-moj)
approved these changes
Mar 19, 2026
Matt Crowson (matt-crowson-moj)
deleted the
task/OV-449-audit-visit-changes-p2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit changes to staff and prisoner notes.
I also realised the initial length of the details column would not be long enough to support these two fields as they alone are 400 characters each.