Skip to content

PI-3866 Remove deprecated forenames field #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcus-bcl wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

PI-3866 Remove deprecated forenames field #6063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...tier-to-delius/src/integrationTest/kotlin/uk/gov/justice/digital/hmpps/TierDetailsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import org.hamcrest.MatcherAssert.assertThat
import org.hamcrest.Matchers.containsInAnyOrder
import org.junit.jupiter.api.Test
import org.springframework.beans.factory.annotation.Autowired
import org.springframework.boot.webmvc.test.autoconfigure.AutoConfigureMockMvc
import org.springframework.boot.test.context.SpringBootTest
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment.RANDOM_PORT
import org.springframework.boot.webmvc.test.autoconfigure.AutoConfigureMockMvc
import org.springframework.test.web.servlet.MockMvc
import org.springframework.test.web.servlet.get
import uk.gov.justice.digital.hmpps.data.generator.*
Expand Down Expand Up @@ -44,7 +44,7 @@ class TierDetailsTest @Autowired constructor(
.andExpect {
status { is2xxSuccessful() }
jsonPath("$.crn") { value("A000001") }
jsonPath("$.name.forenames") { value("Test") }
jsonPath("$.name.forename") { value("Test") }
jsonPath("$.name.surname") { value("Person") }
jsonPath("$.age") { value(18) }
}
Expand Down
2 changes: 0 additions & 2 deletions ...-to-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/controller/model/PersonDetails.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ data class PersonDetails(

data class Name(
val forename: String,
@Deprecated("Use forename instead", ReplaceWith("forename"))
val forenames: String = forename,
val middleName: String?,
val surname: String
)
Loading