fix: Removed node_modules/ prefix in vendor styles to be compatible with monorepos#1974
Open
Yann イーベス Eves (yanneves) wants to merge 1 commit intoministryofjustice:mainfrom
Open
Conversation
… with monorepos One @forward import in the govuk-frontend vendor dependency includes a superfluous `node_modules/` prefix which makes assumptions on the location of dependencies and breaks monorepo support where dependencies are usually installed in the root directory, i.e. `../../node_modules/`. Fixes ministryofjustice#1781
Author
|
just tagging you directly Chris Pymm (@chrispymm) in case this was missed |
Contributor
|
Hi, thanks for this PR - I have a feeling we have tried to remove this before and it caused issues in Rails projects so I'll have to do a bit of further testing. |
Author
|
could see where Rails might trip up on this if it doesn't default to looking in node_modules/ have you been able to do any further testing? the patched version is creeping further into our build pipeline and feeling a bit fragile |
Author
|
hey Chris Pymm (@chrispymm), I notice there's a new beta release channel, would that be somewhere we could attempt this in case it's a breaking change? we're still unable to use the unpatched version in our monorepo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the bug
Fixes #1781
Description of the change
One Forward (@forward) import in the govuk-frontend vendor dependency includes a superfluous
node_modules/prefix which makes assumptions on the location of dependencies and breaks monorepo support where dependencies are usually installed in the root directory, i.e.../../node_modules/.Alternative designs
n/a
Possible drawbacks
n/a
Verification process
Installed patched version locally.
Release notes