ISSUE #198

* Add tests for `RemoteSagaStepDecoratorMeta`.

Author: Sergio García Prado

packages/core/minos-microservice-saga/minos/saga/definitions/steps/remote.py

@@ -11,7 +11,9 @@
 from typing import (
     Any,
     Optional,
+    Protocol,
     Union,
+    runtime_checkable,
 )
 
 from cached_property import (
@@ -48,7 +50,8 @@
 )
 
 
-class RemoteSagaStepDecoratorWrapper(SagaStepDecoratorWrapper):
+@runtime_checkable
+class RemoteSagaStepDecoratorWrapper(SagaStepDecoratorWrapper, Protocol):
     """TODO"""
 
     meta: RemoteSagaStepDecoratorMeta
@@ -150,11 +153,14 @@ def __call__(self, func: RequestCallBack) -> RemoteSagaStepDecoratorWrapper:
         return func
 
     def on_execute(
-        self, callback: RequestCallBack, parameters: Optional[SagaContext] = None, **kwargs
+        self,
+        operation: Union[SagaOperation[RequestCallBack], RequestCallBack],
+        parameters: Optional[SagaContext] = None,
+        **kwargs,
     ) -> RemoteSagaStep:
         """On execute method.
 
-        :param callback: The callback function to be called.
+        :param operation: The callback function to be called.
         :param parameters: A mapping of named parameters to be passed to the callback.
         :param kwargs: A set of named arguments to be passed to the callback. ``parameters`` has order if it is not
             ``None``.
@@ -163,16 +169,22 @@ def on_execute(
         if self.on_execute_operation is not None:
             raise MultipleOnExecuteException()
 
-        self.on_execute_operation = SagaOperation(callback, parameters, **kwargs)
+        if not isinstance(operation, SagaOperation):
+            operation = SagaOperation(operation, parameters, **kwargs)
+
+        self.on_execute_operation = operation
 
         return self
 
     def on_failure(
-        self, callback: RequestCallBack, parameters: Optional[SagaContext] = None, **kwargs
+        self,
+        operation: Union[SagaOperation[RequestCallBack], RequestCallBack],
+        parameters: Optional[SagaContext] = None,
+        **kwargs,
     ) -> RemoteSagaStep:
         """On failure method.
 
-        :param callback: The callback function to be called.
+        :param operation: The callback function to be called.
         :param parameters: A mapping of named parameters to be passed to the callback.
         :param kwargs: A set of named arguments to be passed to the callback. ``parameters`` has order if it is not
             ``None``.
@@ -181,16 +193,22 @@ def on_failure(
         if self.on_failure_operation is not None:
             raise MultipleOnFailureException()
 
-        self.on_failure_operation = SagaOperation(callback, parameters, **kwargs)
+        if not isinstance(operation, SagaOperation):
+            operation = SagaOperation(operation, parameters, **kwargs)
+
+        self.on_failure_operation = operation
 
         return self
 
     def on_success(
-        self, callback: ResponseCallBack, parameters: Optional[SagaContext] = None, **kwargs
+        self,
+        operation: Union[SagaOperation[ResponseCallBack], ResponseCallBack],
+        parameters: Optional[SagaContext] = None,
+        **kwargs,
     ) -> RemoteSagaStep:
         """On success method.
 
-        :param callback: The callback function to be called.
+        :param operation: The callback function to be called.
         :param parameters: A mapping of named parameters to be passed to the callback.
         :param kwargs: A set of named arguments to be passed to the callback. ``parameters`` has order if it is not
             ``None``.
@@ -199,16 +217,22 @@ def on_success(
         if self.on_success_operation is not None:
             raise MultipleOnSuccessException()
 
-        self.on_success_operation = SagaOperation(callback, parameters, **kwargs)
+        if not isinstance(operation, SagaOperation):
+            operation = SagaOperation(operation, parameters, **kwargs)
+
+        self.on_success_operation = operation
 
         return self
 
     def on_error(
-        self, callback: ResponseCallBack, parameters: Optional[SagaContext] = None, **kwargs
+        self,
+        operation: Union[SagaOperation[ResponseCallBack], ResponseCallBack],
+        parameters: Optional[SagaContext] = None,
+        **kwargs,
     ) -> RemoteSagaStep:
         """On error method.
 
-        :param callback: The callback function to be called.
+        :param operation: The callback function to be called.
         :param parameters: A mapping of named parameters to be passed to the callback.
         :param kwargs: A set of named arguments to be passed to the callback. ``parameters`` has order if it is not
             ``None``.
@@ -217,7 +241,10 @@ def on_error(
         if self.on_error_operation is not None:
             raise MultipleOnErrorException()
 
-        self.on_error_operation = SagaOperation(callback, parameters, **kwargs)
+        if not isinstance(operation, SagaOperation):
+            operation = SagaOperation(operation, parameters, **kwargs)
+
+        self.on_error_operation = operation
 
         return self
 

packages/core/minos-microservice-saga/tests/test_saga/test_definitions/test_steps/test_local.py

@@ -36,6 +36,7 @@ def test_on_failure(self):
         def _fn(context: SagaContext) -> SagaContext:
             """For testing purposes"""
 
+        # noinspection PyUnusedLocal
         @_fn.on_failure()
         def _fn2(context: SagaContext) -> SagaContext:
             """For testing purposes"""

packages/core/minos-microservice-saga/tests/test_saga/test_definitions/test_steps/test_remote.py

@@ -7,7 +7,11 @@
     MultipleOnFailureException,
     MultipleOnSuccessException,
     RemoteSagaStep,
+    RemoteSagaStepDecoratorMeta,
+    RemoteSagaStepDecoratorWrapper,
+    SagaContext,
     SagaOperation,
+    SagaRequest,
     SagaStep,
     UndefinedOnExecuteException,
 )
@@ -19,6 +23,67 @@
 )
 
 
+class TestRemoteSagaStepDecoratorMeta(unittest.TestCase):
+    def test_constructor(self):
+        # noinspection PyUnusedLocal
+        @RemoteSagaStep()
+        def _fn(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        self.assertIsInstance(_fn, RemoteSagaStepDecoratorWrapper)
+        meta = _fn.meta
+        self.assertIsInstance(meta, RemoteSagaStepDecoratorMeta)
+        self.assertEqual(RemoteSagaStep(_fn), meta.definition)
+
+    def test_on_failure(self):
+        # noinspection PyUnusedLocal
+        @RemoteSagaStep()
+        def _fn(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        # noinspection PyUnusedLocal
+        @_fn.on_failure()
+        def _fn2(context: SagaContext) -> SagaRequest:
+            """For testing purposes"""
+
+        self.assertIsInstance(_fn, RemoteSagaStepDecoratorWrapper)
+        meta = _fn.meta
+        self.assertIsInstance(meta, RemoteSagaStepDecoratorMeta)
+        self.assertEqual(RemoteSagaStep(_fn, on_failure=_fn2), meta.definition)
+
+    def test_on_success(self):
+        # noinspection PyUnusedLocal
+        @RemoteSagaStep()
+        def _fn(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        # noinspection PyUnusedLocal
+        @_fn.on_success()
+        def _fn2(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        self.assertIsInstance(_fn, RemoteSagaStepDecoratorWrapper)
+        meta = _fn.meta
+        self.assertIsInstance(meta, RemoteSagaStepDecoratorMeta)
+        self.assertEqual(RemoteSagaStep(_fn, on_success=_fn2), meta.definition)
+
+    def test_on_error(self):
+        # noinspection PyUnusedLocal
+        @RemoteSagaStep()
+        def _fn(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        # noinspection PyUnusedLocal
+        @_fn.on_error()
+        def _fn2(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        self.assertIsInstance(_fn, RemoteSagaStepDecoratorWrapper)
+        meta = _fn.meta
+        self.assertIsInstance(meta, RemoteSagaStepDecoratorMeta)
+        self.assertEqual(RemoteSagaStep(_fn, on_error=_fn2), meta.definition)
+
+
 class TestRemoteSagaStep(unittest.TestCase):
     def test_on_execute_constructor(self):
         step = RemoteSagaStep(on_execute=send_create_ticket)