Skip to content

Commit 912b7ef

Browse files
author
Sergio García Prado
committed
* Improve log messages.
1 parent eaafb51 commit 912b7ef

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

packages/core/minos-microservice-networks/minos/networks/brokers/dispatchers/impl.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
)
44

55
import logging
6+
import traceback
67
from collections.abc import (
78
Awaitable,
89
Callable,
@@ -152,10 +153,12 @@ async def _wrapper(raw: BrokerMessage) -> BrokerMessageV1Payload:
152153
else:
153154
content, status = None, BrokerMessageV1Status.SUCCESS
154155
except ResponseException as exc:
155-
logger.error(f"Raised an application exception: {exc!s}")
156+
tb = traceback.format_exc()
157+
logger.error(f"Raised an application exception:\n {tb}")
156158
content, status = repr(exc), exc.status
157159
except Exception as exc:
158-
logger.exception(f"Raised a system exception: {exc!r}")
160+
tb = traceback.format_exc()
161+
logger.exception(f"Raised a system exception:\n {tb}")
159162
content, status = repr(exc), BrokerMessageV1Status.SYSTEM_ERROR
160163
finally:
161164
headers = REQUEST_HEADERS_CONTEXT_VAR.get()

packages/core/minos-microservice-networks/minos/networks/http/connectors.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ async def start(self) -> None:
8484
:return: This method does not return anything.
8585
"""
8686

87+
logger.info(f"Starting {self!r}...")
8788
self.mount_routes()
8889
await self._start()
8990

@@ -92,6 +93,7 @@ async def stop(self) -> None:
9293
9394
:return: This method does not return anything.
9495
"""
96+
logger.info(f"Stopping {self!r}...")
9597
await self._stop()
9698

9799
@abstractmethod
@@ -205,3 +207,6 @@ def adapter(self) -> HttpAdapter:
205207
:return: A ``int`` value.
206208
"""
207209
return self._adapter
210+
211+
def __repr__(self):
212+
return f"{type(self).__name__}({self._host!r}, {self._port})"

packages/core/minos-microservice-networks/minos/networks/scheduling/schedulers.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import asyncio
66
import logging
7+
import traceback
78
from contextlib import (
89
suppress,
910
)
@@ -185,15 +186,18 @@ async def run_once(self, now: Optional[datetime] = None) -> None:
185186

186187
request = ScheduledRequest(now)
187188
logger.debug("Running periodic task...")
189+
# noinspection PyBroadException
188190
try:
189191
self._running = True
190192
with suppress(asyncio.CancelledError):
191193
response = self._fn(request)
192194
if isawaitable(response):
193195
await response
194-
except ResponseException as exc:
195-
logger.error(f"Raised an application exception: {exc!s}")
196-
except Exception as exc:
197-
logger.exception(f"Raised a system exception: {exc!r}")
196+
except ResponseException:
197+
tb = traceback.format_exc()
198+
logger.error(f"Raised an application exception:\n {tb}")
199+
except Exception:
200+
tb = traceback.format_exc()
201+
logger.exception(f"Raised a system exception:\n {tb}")
198202
finally:
199203
self._running = False

packages/plugins/minos-http-aiohttp/minos/plugins/aiohttp/connectors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ async def _build_error_response(self, message: str, status: int) -> web.Response
9090
return web.Response(text=message, status=status)
9191

9292
async def _start(self) -> None:
93-
self._runner = web_runner.AppRunner(self.application)
93+
self._runner = web_runner.AppRunner(self.application, access_log=None)
9494
await self._runner.setup()
9595

9696
self._site = web_runner.TCPSite(

0 commit comments

Comments
 (0)