Skip to content

refactor(tests): update test descriptions to English #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minseong0324 merged 1 commit into from
Feb 24, 2026
Merged

refactor(tests): update test descriptions to English #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions packages/core/tests/action-observer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('ActionObserver', () => {
ConnectivityClient.resetInstance();
});

test('constructor에서 action을 등록한다', async () => {
test('registers action in constructor', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -42,11 +42,11 @@ describe('ActionObserver', () => {
request: vi.fn().mockResolvedValue('ok'),
});

// action이 등록되었으므로 execute가 throw하지 않아야 함
// action is registered, so execute should not throw
await expect(client.execute('save', {})).resolves.toBeDefined();
});

test('setOptions로 action을 재등록한다', async () => {
test('re-registers action via setOptions', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -67,7 +67,7 @@ describe('ActionObserver', () => {
expect(fn2).toHaveBeenCalledOnce();
});

test('getCurrentResult가 pendingCount와 lastError를 반환한다', async () => {
test('getCurrentResult returns pendingCount and lastError', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -87,7 +87,7 @@ describe('ActionObserver', () => {
expect(result.lastError).toBeUndefined();
});

test('execute 성공 시 onSuccess callback이 호출된다', async () => {
test('onSuccess callback is called when execute succeeds', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -105,7 +105,7 @@ describe('ActionObserver', () => {
expect(onSuccess).toHaveBeenCalledWith({ id: '42' });
});

test('execute 큐잉 시 onEnqueued callback이 호출된다', async () => {
test('onEnqueued callback is called when execute is queued', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -124,7 +124,7 @@ describe('ActionObserver', () => {
expect(onEnqueued).toHaveBeenCalledWith(expect.stringContaining('job_'));
});

test('execute 실패 + onError callback이 에러를 삼킨다', async () => {
test('execute failure + onError callback swallows error', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -134,20 +134,20 @@ describe('ActionObserver', () => {
const observer = new ActionObserver(client, {
actionKey: 'save',
request: async () => {
throw new Error('실패');
throw new Error('failed');
},
});
observer.setCallbacks({ onError });

const result = await observer.execute({});

expect(onError).toHaveBeenCalledWith(
expect.objectContaining({ message: '실패' }),
expect.objectContaining({ message: 'failed' }),
);
expect(result).toBeUndefined();
});

test('onSettled가 성공/실패 모두에서 호출된다', async () => {
test('onSettled is called on both success and failure', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -164,7 +164,7 @@ describe('ActionObserver', () => {
expect(onSettled).toHaveBeenCalledOnce();
});

test('getCurrentResult는 값이 같으면 동일 참조를 반환한다 (memoize)', async () => {
test('getCurrentResult returns same reference when value is equal (memoize)', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -181,11 +181,11 @@ describe('ActionObserver', () => {
const result1 = observer.getCurrentResult();
const result2 = observer.getCurrentResult();

// 값이 같으므로 같은 참조 → useSyncExternalStore가 re-render하지 않음
// same value → same reference → useSyncExternalStore does not re-render
expect(result1).toBe(result2);
});

test('getCurrentResult는 값이 달라지면 새 참조를 반환한다', async () => {
test('getCurrentResult returns new reference when value changes', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -207,7 +207,7 @@ describe('ActionObserver', () => {
expect(result1).not.toBe(result2);
});

test('다른 action의 큐 변경 시 getCurrentResult 참조가 유지된다', async () => {
test('getCurrentResult reference is preserved when other action queue changes', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -227,16 +227,16 @@ describe('ActionObserver', () => {
await observer.execute({});
const result1 = observer.getCurrentResult();

// 다른 action에 job 추가
// add job to other action
await client.execute('other', {});

const result2 = observer.getCurrentResult();

// save의 pendingCount는 여전히 1 → 같은 참조
// save's pendingCount is still 1 → same reference
expect(result1).toBe(result2);
});

test('setCallbacks로 callback을 갱신하면 최신 callback이 호출된다', async () => {
test('updating callback via setCallbacks invokes the latest callback', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -250,16 +250,16 @@ describe('ActionObserver', () => {
});

observer.setCallbacks({ onSuccess: onSuccess1 });
observer.setCallbacks({ onSuccess: onSuccess2 }); // 갱신
observer.setCallbacks({ onSuccess: onSuccess2 }); // update

await observer.execute({});

expect(onSuccess1).not.toHaveBeenCalled();
expect(onSuccess2).toHaveBeenCalledOnce();
});

describe('flush 경로 콜백', () => {
test('flush 성공 시 onSuccess와 onSettled가 호출된다', async () => {
describe('flush path callbacks', () => {
test('onSuccess and onSettled are called when flush succeeds', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -283,7 +283,7 @@ describe('ActionObserver', () => {
expect(onSettled).toHaveBeenCalledOnce();
});

test('flush 최종 실패 시 onError와 onSettled가 호출된다', async () => {
test('onError and onSettled are called when flush finally fails', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -293,7 +293,7 @@ describe('ActionObserver', () => {
const onSettled = vi.fn();
const observer = new ActionObserver(client, {
actionKey: 'save',
request: vi.fn().mockRejectedValue(new Error('flush 실패')),
request: vi.fn().mockRejectedValue(new Error('flush failed')),
whenOffline: 'queue',
});
observer.setCallbacks({ onError, onSettled });
Expand All @@ -304,12 +304,12 @@ describe('ActionObserver', () => {
await vi.advanceTimersByTimeAsync(0);

expect(onError).toHaveBeenCalledWith(
expect.objectContaining({ message: 'flush 실패' }),
expect.objectContaining({ message: 'flush failed' }),
);
expect(onSettled).toHaveBeenCalledOnce();
});

test('flush 시 setCallbacks 갱신 후 최신 callback이 호출된다', async () => {
test('latest callback is called after setCallbacks update during flush', async () => {
const mock = createMockDetector();
const client = getConnectivityClient({ detectors: [mock.detector] });
client.start();
Expand All @@ -326,7 +326,7 @@ describe('ActionObserver', () => {
observer.setCallbacks({ onSuccess: onSuccess1 });
await observer.execute({});

observer.setCallbacks({ onSuccess: onSuccess2 }); // re-render 시뮬레이션
observer.setCallbacks({ onSuccess: onSuccess2 }); // simulate re-render

mock.emit({ status: 'online', reason: 'test' });
await vi.advanceTimersByTimeAsync(0);
Expand Down
6 changes: 3 additions & 3 deletions packages/core/tests/action-options.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { describe, expect, test } from 'vitest';
import { actionOptions } from '../src/action-options';

describe('actionOptions', () => {
test('입력 config를 그대로 반환한다 (identity function)', () => {
test('returns input config as-is (identity function)', () => {
const config = {
actionKey: 'save',
request: async (input: { id: string }) => ({ saved: true, id: input.id }),
Expand All @@ -11,7 +11,7 @@ describe('actionOptions', () => {
expect(actionOptions(config)).toBe(config);
});

test('dedupeKey에서 input 타입이 request의 input과 동일하게 추론된다', () => {
test('dedupeKey input type is inferred same as request input', () => {
const opts = actionOptions({
actionKey: 'save',
request: async (_input: { designId: string; data: string }) => ({
Expand All @@ -22,7 +22,7 @@ describe('actionOptions', () => {
expect(opts.dedupeKey?.({ designId: 'd1', data: 'v1' })).toBe('d1');
});

test('모든 옵션 필드가 보존된다', () => {
test('all option fields are preserved', () => {
const opts = actionOptions({
actionKey: 'upload',
request: async (_input: { file: string }) => ({ url: 'https://...' }),
Expand Down
Loading