Skip to content

INFRA-39812: Test asdf 0.18#222

Open
nthomas91 wants to merge 4 commits intomainfrom
INFRA-39812_test_asdf_0.16
Open

INFRA-39812: Test asdf 0.18#222
nthomas91 wants to merge 4 commits intomainfrom
INFRA-39812_test_asdf_0.16

Conversation

@nthomas91
Copy link
Contributor

@nthomas91 nthomas91 commented Feb 24, 2026

modules/asdf/Makefile - Complete rewrite of the install target:

  • Old: git clone the asdf repo into ~/.asdf, then source asdf.sh to make it available
  • New: Downloads a pre-built binary tarball from GitHub releases into ~/.local/bin
  • Adds version pinning (ASDF_VERSION := 0.18.0) with a check-and-upgrade mechanism - skips reinstall if the correct version is already present
  • PATH guidance updated: ~/.asdf/bin is no longer needed, replaced with ~/.local/bin + ~/.asdf/shims

.github/workflows/asdf.yml:

  • Bumps asdf-vm/actions/setup and asdf-vm/actions/install from @v2 to @v4

@nthomas91 nthomas91 marked this pull request as draft February 24, 2026 14:43
@nabadger
Copy link
Contributor

nabadger commented Feb 25, 2026

This fails for me - switch to this branch, then run make asdf/install

Think it's specific to my own setup though...


Creating bin directory
Cleaning previous binaries
Copying binary
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 19.7M  100 19.7M    0     0  14.3M      0  0:00:01  0:00:01 --:--:-- 22.4M
Downloading yamllint from https://files.pythonhosted.org/packages/a5/ae/2622262d7a5c6af2af85e5edd86f4cf183628e88407942aa0be487b582b6/yamllint-1.29.0.tar.gz to /home/nb/.asdf/downloads/yamllint/1.29.0
Verifying checksum for /home/nb/.asdf/downloads/yamllint/1.29.0/yamllint-1.29.0.tar.gz
The virtual environment was not created successfully because ensurepip is not
available.  On Debian/Ubuntu systems, you need to install the python3-venv
package using the following command.

    apt install python3.10-venv

You may need to use sudo with that command.  After installing the python3-venv
package, recreate your virtual environment.

Failing command: /home/nb/.asdf/installs/yamllint/1.29.0/yamllint-1.29.0/__venv__/bin/python3

Error: failed to create a virtual environment in /home/nb/.asdf/installs/yamllint/1.29.0/yamllint-1.29.0/__venv__
Creating bin directory
Downloading yq from https://github.com/mikefarah/yq/releases/download/v4.31.2/yq_linux_amd64 to /home/nb/.asdf/installs/yq/4.31.2/bin/yq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 11.8M  100 11.8M    0     0  24.9M      0 --:--:-- --:--:-- --:--:-- 24.9M
failed to run install callback: exit status 1
make: *** [/home/nb/jsonnet/sre/core-cluster-jsonnet/build-harness/../build-harness-extensions/modules/asdf/Makefile:11: asdf/install] Error 1

@nthomas91 nthomas91 changed the title INFRA-39812: Test asdf 0.16 INFRA-39812: Test asdf 0.18 Feb 25, 2026
@nthomas91 nthomas91 marked this pull request as ready for review February 25, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants