Skip to content

Commit 6677525

Browse files
authored
Fixes from code block feedback (#1837)
* add intercom placeholder value * fix Osano code block * remove deprecated attribute
1 parent d94784c commit 6677525

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

create/image-embeds.mdx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ Embed YouTube videos using iframe elements:
124124
className="w-full aspect-video rounded-xl"
125125
src="https://www.youtube.com/embed/4KzFe50RQkQ"
126126
title="YouTube video player"
127-
frameBorder="0"
128127
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
129128
allowFullScreen
130129
></iframe>
@@ -135,7 +134,6 @@ Embed YouTube videos using iframe elements:
135134
className="w-full aspect-video rounded-xl"
136135
src="https://www.youtube.com/embed/4KzFe50RQkQ"
137136
title="YouTube video player"
138-
frameBorder="0"
139137
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
140138
allowFullScreen
141139
></iframe>

integrations/privacy/osano.mdx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,23 @@ Add the following to your `docs.json` file to add the [Osano](https://www.osano.
1010

1111
```json Integration options in docs.json
1212
"integrations": {
13-
"osano": "SOURCE"
13+
"osano": {
14+
"scriptSource": "SOURCE"
15+
}
1416
}
1517
```
1618

1719
```json Example
1820
"integrations": {
19-
"osano": "https://cmp.osano.com/2sUB2dqwqdkks/8dqwd-dwd86£-4a9b/osano.js"
21+
"osano": {
22+
"scriptSource": "https://cmp.osano.com/2sUB2dqwqdkks/8dqwd-dwd86£-4a9b/osano.js"
23+
}
2024
}
2125
```
2226

2327
</CodeGroup>
2428

25-
The `SOURCE` can be found as the `src` value in the code snippet generated by Osano. It always starts with `https://cmp.osano.com/`.
29+
The `scriptSource` value can be found as the `src` value in the code snippet generated by Osano. It always starts with `https://cmp.osano.com/` and ends with `/osano.js`.
2630

2731
```html Code snippet from Osano
2832
<script src="https://cmp.osano.com/placeholder/placeholder/osano.js"/>

integrations/support/intercom.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Add the following to your `docs.json` file to add an [Intercom](https://www.inte
1919
```json Example
2020
"integrations": {
2121
"intercom": {
22-
"appId": "APP_ID"
22+
"appId": "abc123def4"
2323
}
2424
}
2525
```

0 commit comments

Comments
 (0)