Skip to content

Conversation

@JazzyMichael
Copy link

@JazzyMichael JazzyMichael commented Sep 24, 2025

Documentation changes

This adds instructions on how to change icon libraries in docs.json


I'm also interested in an open role for a Senior Frontend Engineer in SF, check out my Mintlify site here, I would love to set up an interview!

Tagging @dino475 & @ethanpalm based on the most recent changes from this PR 971

For Reviewers

When reviewing documentation PRs, please consider:

✅ Technical accuracy

  • Code examples work as written
  • Commands and configurations are correct
  • Links resolve to the right destinations
  • Prerequisites and requirements are accurate

✅ Clarity and completeness

  • Instructions are clear and easy to follow
  • Steps are in logical order
  • Nothing important is missing
  • Examples help illustrate the concepts

✅ User experience

  • A new user could follow these docs successfully
  • Common gotchas or edge cases are addressed
  • Error messages or troubleshooting guidance is helpful

@ethanpalm
Copy link
Collaborator

Hey @JazzyMichael, thanks for opening a PR. We're not going to accept this contribution since the icons-required snippet just contains information for that specific property and not info about global icon library settings.

I encourage you to apply through the Senior Frontend Engineer job posting, if you haven't already.

Appreciate you taking the time to look through and contribute to the Mintlify docs 😄

@ethanpalm ethanpalm closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants