Skip to content

Fix prop requirements in Global Settings #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix prop requirements in Global Settings #330

merged 1 commit into from
Nov 6, 2024

Conversation

fmerian
Copy link
Contributor

@fmerian fmerian commented Nov 6, 2024

  • #.anchors[0].name: This field is required
  • #.topAnchor.name: This field is required

@fmerian fmerian requested a review from hahnbeelee November 6, 2024 11:04
hahnbeelee
hahnbeelee approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@hahnbeelee hahnbeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmerian fmerian merged commit 24f1616 into main Nov 6, 2024
2 checks passed
@fmerian fmerian deleted the fix-required-props-global-settings branch November 6, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hahnbeelee hahnbeelee hahnbeelee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fmerian @hahnbeelee