Skip to content

fix: remove overloaded properties of OpenIDConnectClient #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 11, 2025
Merged

fix: remove overloaded properties of OpenIDConnectClient #45

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1ee52e8
fix: remove overloaded properties of OpenIDConnectClient
ricklambrechts Sep 27, 2024
0ffd977
fix: remove unneeded excluded path of phpstan config
ricklambrechts Sep 30, 2024
5216e35
test: add test for state does not match exception and added needed su…
ricklambrechts Sep 30, 2024
42eb9da
test: add test for state does not match exception and added needed su…
ricklambrechts Sep 30, 2024
c683a4b
test: add test for invalid signed id token
ricklambrechts Sep 30, 2024
6d1efec
test: add test for client secret signed user info
ricklambrechts Sep 30, 2024
6ba58e5
test: add test to test exception when sub claims differ.
ricklambrechts Sep 30, 2024
da2afed
fix: rename overloaded responseContentType to internalResponseContent…
ricklambrechts Feb 10, 2025
ea97d73
fix: remove typescript for linter
ricklambrechts Feb 10, 2025
5572f8d
fix: set psalm var type for linter
ricklambrechts Feb 10, 2025
04c504d
chore: use example.com as example domain name
ricklambrechts Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"require": {
"php": ">=8.1",
"jumbojett/openid-connect-php": "^1.0.0",
"jumbojett/openid-connect-php": "^1.0.2",
"guzzlehttp/guzzle": "^7.5",
"web-token/jwt-library": "^3.4"
},
Expand Down
9 changes: 0 additions & 9 deletions src/OpenIDConnectClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,6 @@ class OpenIDConnectClient extends \Jumbojett\OpenIDConnectClient
{
protected ?JweDecryptInterface $jweDecrypter;
protected ?OpenIDConfiguration $openIDConfiguration;
/**
* @var int|null Response code from the server
*/
protected ?int $responseCode;

/**
* @var string|null Content type from the server
*/
private ?string $responseContentType;

public function __construct(
?string $providerUrl = null,
Expand Down
Loading