add endSessionEndpoint to configuration to support ending the session #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maarten-v
force-pushed
the
support-ending-session
branch
2 times, most recently
from
28dd49f to
31522bc
Compare
maarten-v
force-pushed
the
support-ending-session
branch
2 times, most recently
from
2a92008 to
f7f051b
Compare
|
In case someone is waiting for the pipeline to succeed, the pipeline is complaining about missing environment variable SONAR_TOKEN which a repository owner should add. |
|
Hi @maarten-v, thanks for the PR and your patience. Already had a quick look. We will update the actions to not run the sonarcloud action on forks. Expect to look further to your PR next week. |
maarten-v
force-pushed
the
support-ending-session
branch
from
f7f051b to
6ab8afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openid package that this package uses "jumbojett/openid-connect-php" has a signout functionality to end the session on the remote server: https://github.com/jumbojett/OpenID-Connect-PHP/blob/master/src/OpenIDConnectClient.php#L435
See https://openid.net/specs/openid-connect-session-1_0-17.html#rfc.section.2.1
This is not working when using this package because the end session url from the well known config is not loaded.
This MR fixes that and makes it possible to use the signout functionality.