Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
============================================
+ Coverage 31.80% 31.82% +0.01%
Complexity 815 815
============================================
Files 47 47
Lines 3723 3724 +1
============================================
+ Hits 1184 1185 +1
Misses 2539 2539 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| */ | ||
| public function resetDatabaseLists( bool $isNewChanges ): void { | ||
| // @phan-suppress-next-line PhanDisallowedOptionalMethodParameter | ||
| public function resetDatabaseLists( bool $isNewChanges, ?string $caller = null ): void { |
There was a problem hiding this comment.
No optional params please. Explicitly pass empty string and check where we dont want it. Easier to read at call sites as well that way. Though really it should just always be passed as __METHOD__ anyway, and only accept strings, then you can also avoid ?? 'unknown' which would not help at all, and there really is no reason to not pass it even if we arent using it.
|
|
||
| public const EmailNotifications = 'CreateWikiEmailNotifications'; | ||
|
|
||
| public const TrackDatabaseListMetrics = 'CreateWikiTrackDatabaseListMetrics'; |
There was a problem hiding this comment.
Alphabetical order please.
| $this->localServerCache->makeGlobalKey( self::CACHE_KEY, 'databases-local' ) | ||
| ); | ||
|
|
||
| $this->trackDatabaseListMetrics = $this->options->get( ConfigNames::TrackDatabaseListMetrics ); |
There was a problem hiding this comment.
Don't really need to do a property here and just use the option directly since its only used once.
2 participants
No description provided.