-
Notifications
You must be signed in to change notification settings - Fork 85
WIP β Realign boilerplate with mix phx.new
#249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e0f37a8 to
f5171d3
Compare
|
Thanks for your work on the |
|
Hey @willjleong, we are glad the templates is valuable to you β€οΈ Let me |
|
I just submitted an update to the latest Debian release : #324 As soon as it gets ππ» Iβll do the |
b59c9d2 to
c4d24af
Compare
|
π¦ Requesting reviewers for this pull request:
|
ab5691d to
6ecb56f
Compare
6ecb56f to
9790823
Compare
β¦ at runtime using environment variables
9790823 to
33fd401
Compare
@gcauchon Since you mentioned this βοΈ in #359, we can close this PR? (Or at least put it back in draft mode) |
|
Yes! |
mix phx.new
π Description
Now that the official release of Phoenix
1.7have seen multiple maintenance releases, here is an open discussion about how we could adapt our boilerplate project to follow the community conventions to simplify future evolution as things are moving forward rapidly in the Erlang/Elixir/Phoenix ecosystem.π References
I used the community tool to highlight the gap between
1.6and1.7:I had to change a few things because we diverged from the community patterns a few version back and it doesn't fit well in the new functional component approach. Especially if we want to leverage component reusability between dead and live views:
heexwith the new "view-module-less" approach;CredoNaming.Check.Consistency.ModuleFilenamefor now since the validation rule do not match the new file structure convention with functional components.ElixirBoilerplateWeb.Routermodule.routerand a customplugto catch an haltedConnwas a red flag in my mind;ElixirBoilerplateWebmodule and the__using__macro to encapsulate the router/controller/html/live_view and live_component boilerplate likephx.newand the generators does;Absintheconfiguration and added the missing dependency to supportSubscriptionover web socket;Sessionmodule which pulls the sessionkeyandsigning_salffrom environment variable at runtime. So we can use it right in both dead and live views;Ectoschema and it corresponding migration so we are using--binary_id.π¦ Dispatch
#dispatch/elixir