Skip to content

fix sub-variables are not correctly recovered from sub-fields#325

Merged
DamianCzajkowski merged 3 commits intomirumee:mainfrom
flonou:Variables-from-subfields-are-not-correctly-recovered
Oct 20, 2025
Merged

fix sub-variables are not correctly recovered from sub-fields#325
DamianCzajkowski merged 3 commits intomirumee:mainfrom
flonou:Variables-from-subfields-are-not-correctly-recovered

Conversation

@flonou
Copy link
Contributor

@flonou flonou commented Nov 4, 2024

fixes #323
variables from sub-fields are not correctly recovered. The code access the variables but doesn't pass them to the structure

@flonou
Copy link
Contributor Author

flonou commented Jul 15, 2025

Hi, could this be reviewed and eventually merged ?

@DamianCzajkowski
Copy link
Collaborator

Hi @flonou, Sorry for the late response. Thanks for the pull request. Unfortunately, I believe it's going to fail some tests in the repo. If you can fix the tests and provide some examples of what was wrong here, it will be helpful for me and for the others. Thanks!

If there will be no response from @flonou on this pull request, I'm taking it to verify if it's valid and prepare the solution for #323

@DamianCzajkowski DamianCzajkowski added the help wanted Extra attention is needed label Oct 8, 2025
@flonou flonou force-pushed the Variables-from-subfields-are-not-correctly-recovered branch from 2da07a1 to bd04a6b Compare October 19, 2025 21:06
@flonou
Copy link
Contributor Author

flonou commented Oct 19, 2025

Hi! I fixed the tests. I'm however a bit sceptical as to why some files are compared that way, but I guess that would be the scope of another PR if that needs to be changed

@DamianCzajkowski
Copy link
Collaborator

@flonou, it looks like hatch is failing
Try to run:

hatch fmt --check
hatch run types:check

and then tests:
hatch test

@flonou
Copy link
Contributor Author

flonou commented Oct 20, 2025

I fixed formatting but run types:check fails (maybe due to windows environment ?)

hatch run types:check --show-traceback
cmd [1] | mypy tests/main/clients/*/expected_client
mypy: can't read file 'tests\main\clients*\expected_client': Invalid argument

@DamianCzajkowski
Copy link
Collaborator

Perfect! it works now

@DamianCzajkowski DamianCzajkowski merged commit 205567c into mirumee:main Oct 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variables from subfields are not correctly recovered

2 participants