fix sub-variables are not correctly recovered from sub-fields#325
Conversation
|
Hi, could this be reviewed and eventually merged ? |
|
Hi @flonou, Sorry for the late response. Thanks for the pull request. Unfortunately, I believe it's going to fail some tests in the repo. If you can fix the tests and provide some examples of what was wrong here, it will be helpful for me and for the others. Thanks! If there will be no response from @flonou on this pull request, I'm taking it to verify if it's valid and prepare the solution for #323 |
2da07a1 to
bd04a6b
Compare
|
Hi! I fixed the tests. I'm however a bit sceptical as to why some files are compared that way, but I guess that would be the scope of another PR if that needs to be changed |
|
@flonou, it looks like hatch is failing hatch fmt --check and then tests: |
|
I fixed formatting but run types:check fails (maybe due to windows environment ?)
|
|
Perfect! it works now |
fixes #323
variables from sub-fields are not correctly recovered. The code access the variables but doesn't pass them to the structure