enhance: アバターデコレーションへのカテゴリの導入 #17034
Open
+133
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
github-actions
bot
added
packages/frontend
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #17034 +/- ##
===========================================
+ Coverage 62.77% 62.82% +0.04%
===========================================
Files 1150 1152 +2
Lines 114944 115181 +237
Branches 7862 7899 +37
===========================================
+ Hits 72157 72358 +201
- Misses 40643 40678 +35
- Partials 2144 2145 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Backend Memory Usage Comparison
|
Contributor
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -3310,6 +3310,12 @@
"items": {
"type": "string"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
@@ -3359,6 +3365,12 @@
"type": "string",
"format": "id"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
@@ -3368,7 +3380,8 @@
"name",
"description",
"url",
- "roleIdsThatCanBeUsedThisDecoration"
+ "roleIdsThatCanBeUsedThisDecoration",
+ "category"
]
}
}
@@ -3727,6 +3740,12 @@
"type": "string",
"format": "id"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
@@ -3895,6 +3914,12 @@
"items": {
"type": "string"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [
@@ -51319,6 +51344,12 @@
"type": "string",
"format": "id"
}
+ },
+ "category": {
+ "type": [
+ "string",
+ "null"
+ ]
}
},
"required": [ |
EbiseLutica
force-pushed
the
feature/avatar-decoration-category
branch
from
7b5389a to
844bf91
Compare
Member
|
（追加されたUIのキャプチャがあるとレビューがスムーズかもしれません） |
Contributor
Author
|
画面キャプチャを追加しておきました |
Contributor
kakkokari-gtyih
left a comment
kakkokari-gtyih
left a comment
There was a problem hiding this comment.
group-avatar-decorations.ts が用意されているにも関わらず使われていないかもしれません
| import { ensureSignin } from '@/i.js'; | ||
| import MkInfo from '@/components/MkInfo.vue'; | ||
| import { definePage } from '@/page.js'; | ||
| import { groupAvatarDecorations } from '@/utility/group-avatar-decorations'; |
Contributor
There was a problem hiding this comment.
Suggested change
| import { groupAvatarDecorations } from '@/utility/group-avatar-decorations'; | |
| import { groupAvatarDecorations } from '@/utility/group-avatar-decorations.js'; |
| * @param decorations アバターデコレーションの配列 | ||
| * @returns カテゴリごとにグループ化されたアバターデコレーションオブジェクト | ||
| */ | ||
| export const groupAvatarDecorations = (decorations: AvatarDecoration[]) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| export const groupAvatarDecorations = (decorations: AvatarDecoration[]) => { | |
| export function groupAvatarDecorations(decorations: AvatarDecoration[]) { |
| } | ||
|
|
||
| return grouped; | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| }; | |
| } |
samunohito
reviewed
Dec 25, 2025
Member
samunohito
left a comment
samunohito
left a comment
There was a problem hiding this comment.
バックエンド側実装は問題ないと思います（フロントエンド側は任せた）。
ただ、1点だけ軽微な指摘があります。
Comment on lines
+6
to
+22
| export class AddCategoryToAvatarDecorations1766652173085 { | ||
| name = 'AddCategoryToAvatarDecorations1766652173085'; | ||
|
|
||
| /** | ||
| * @param {QueryRunner} queryRunner | ||
| */ | ||
| async up(queryRunner) { | ||
| await queryRunner.query('ALTER TABLE "avatar_decoration" ADD "category" character varying(128)'); | ||
| } | ||
|
|
||
| /** | ||
| * @param {QueryRunner} queryRunner | ||
| */ | ||
| async down(queryRunner) { | ||
| await queryRunner.query('ALTER TABLE "avatar_decoration" DROP COLUMN "category"'); | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
タブとスペースが混在しているのでフォーマッタをかけていただけると助かります
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
close #16854
アバターデコレーションに、カスタム絵文字と同様にカテゴリを設定できるようにしました。
Why
1画面に収まりきらないほど多くのデコレーションを登録しているサーバーにおいて整理できるようにし、管理画面およびアバターデコレーション設定画面の見通しの改善を支援します
Additional info (optional)
管理画面のスクリーンショット
一覧画面
編集画面
プロフィール画面のスクリーンショット
Checklist