Open
Conversation
Feat explicit UUID mysql
add: Fn to remove constraint from a table
…limit add: Fn to determine dialect-specific byte insertion limit
* If records go beyond 1000000, the ID returned by the oracle driver is of type float64 instead of uint(uint64) * To mitigate this issue, introducing the `primary` struct * The `primary` struct implements the `Scanner` interface to convert float64 and int64 into a unit ID * The `primary` struct implements the `Valuer` interface to return the uint value of the ID it encapsulates * Introducing the `ORM` struct which makes use of the `primary` struct to encapsulate the ID returned by the DB
* This is to mitigate the scenario where the reference to the rowid of the oracle entry is returned as an int64. * This int64 is converted to uint internally by the Scan() implementation of the `primary` struct * Hence, we need to access that converted value by checking if the primary field is of type `primary`
Fix float64 oracle overflow
refactor: Export `Primary` struct outside gorm package
refactor: Remove primary key and foreign key custom structs
refactor: Use primaryField.Field.Uint to get uint when resolving row ID
feat: add support for setting nullable
fix: Resolve row Id when rows>=10^6
feat: add ModifyColumn support in oci8 dialect
* Setting a new instance `gorm:increment_attrs` which will be leveraged in the update callback code * Added a switch in the update callback code making use of the `gorm:increment_attrs` instance to modify the SQL accordingly
add: Method to increment integer attrs for a table's row
fix: Allow increment for floats as well as ints
[AN-62] Custom tags for column types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes checked before submitting your pull request.
For significant changes like big bug fixes, new features, please open an issue to make an agreement on an implementation design/plan first before starting it.
What did this pull request do?
Gorm uses the default value for uint, ie
0, in prepared statements while insertion if no foreign key is provided for a model. Doing so requires a primary key with value0to be present in the referenced table which is often not the case giving rise to errors.This PR replaces this
0withNULL, which should be the actual behaviour.