Fix float64 oracle overflow#4
Open
misterEggroll wants to merge 13 commits intomisterEggroll:masterfrom
Open
Conversation
Feat explicit UUID mysql
add: Fn to remove constraint from a table
…limit add: Fn to determine dialect-specific byte insertion limit
* If records go beyond 1000000, the ID returned by the oracle driver is of type float64 instead of uint(uint64) * To mitigate this issue, introducing the `primary` struct * The `primary` struct implements the `Scanner` interface to convert float64 and int64 into a unit ID * The `primary` struct implements the `Valuer` interface to return the uint value of the ID it encapsulates * Introducing the `ORM` struct which makes use of the `primary` struct to encapsulate the ID returned by the DB
* This is to mitigate the scenario where the reference to the rowid of the oracle entry is returned as an int64. * This int64 is converted to uint internally by the Scan() implementation of the `primary` struct * Hence, we need to access that converted value by checking if the primary field is of type `primary`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gorm.Model, this results in an error when reading from a table with this many rows.gorm.ORMwhich will mitigate this issue and work for all databases by adapting the driver results.sql.Scannerinterface from thedatabase/sqlpackage.uintin theprimarystruct.