Migrating to spatie/laravel-html from laravelcollective/html#40
Open
duganwdobbs wants to merge 19 commits intomisterdebug:masterfrom
Open
Migrating to spatie/laravel-html from laravelcollective/html#40duganwdobbs wants to merge 19 commits intomisterdebug:masterfrom
duganwdobbs wants to merge 19 commits intomisterdebug:masterfrom
Conversation
… for opening and closing the form. /shrug
…rs, floats, etc to input fields.
…sed and how to avoid some necessary escape sequences.
Spatie html
Owner
|
Hi @duganwdobbs, thanks for your contribution. I'm currently working on this issue, and I'm considering removing all dependencies entirely to avoid any future issues. You can find the conversation here: #33 if you'd like to discuss it further :) The idea I'm leaning towards at the moment is to use blade form components, but I'm open to discussing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravelcollective's html generation lib is out of date, so I reworked some things to work with Spatie's instead. The decimal / float / double column feels a bit hacky to me, not sure how else to go about it without thinking more.