Skip to content

Comments

Acoustic Integrator rework#4

Draft
tjueterb wants to merge 25 commits intomasterfrom
feature/energy-loss-stopping-criterion
Draft

Acoustic Integrator rework#4
tjueterb wants to merge 25 commits intomasterfrom
feature/energy-loss-stopping-criterion

Conversation

@tjueterb
Copy link
Member

@tjueterb tjueterb commented Feb 16, 2026

This PR

  • Adds an energy loss stopping criterion to all acoustic integrators
  • Implements several small bugfixes for all acoustic integrators
  • Adds tests for all acoustic integrators

Energy loss stopping criterion.

Stopping after a certain path depth is usually not really helpful in acoustics. Stopping after a certain energy loss (e.g. 65 dB if the goal is estimating T60) leads to the desired path lengths while at the same time not tracing paths with little energy unnecessarily long.

Russian Roulette

A simple stopping criterion without russian roulette techniques introduces bias (the ETC drops off afterwards).
This is usually not a problem.
Do we want to implement russian roulette anyways?

Testing

Checklist

  • Implement for all integrators
  • Add russian roulette logic?
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • My code also compiles for cuda_* and llvm_* variants. If you can't test this, please leave below
  • I have commented my code
  • I have made corresponding changes to the documentation
  • I have added my changes to docs/release-notes.rst
  • I have added tests that prove my fix is effective or that my feature works
  • I cleaned the commit history and removed any "Merge" commits
  • I give permission that the misuka project may redistribute my contributions under the terms of its license

@tjueterb tjueterb self-assigned this Feb 16, 2026
@tjueterb tjueterb added the enhancement New feature or request label Feb 16, 2026
@tjueterb tjueterb force-pushed the feature/energy-loss-stopping-criterion branch 6 times, most recently from 0f630a1 to 381c833 Compare February 17, 2026 11:06
@tjueterb tjueterb force-pushed the feature/energy-loss-stopping-criterion branch from c79f2f6 to 718d5e7 Compare February 19, 2026 15:45
@tjueterb tjueterb force-pushed the feature/energy-loss-stopping-criterion branch from 5896641 to 07ab914 Compare February 23, 2026 15:37
@tjueterb tjueterb force-pushed the feature/energy-loss-stopping-criterion branch from 07ab914 to d39e98a Compare February 23, 2026 15:37
@tjueterb tjueterb changed the title Add energy loss stopping criterion Acoustic Integrator rework Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant