Draft
Conversation
0f630a1 to
381c833
Compare
c79f2f6 to
718d5e7
Compare
5896641 to
07ab914
Compare
07ab914 to
d39e98a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Energy loss stopping criterion.
Stopping after a certain path depth is usually not really helpful in acoustics. Stopping after a certain energy loss (e.g. 65 dB if the goal is estimating T60) leads to the desired path lengths while at the same time not tracing paths with little energy unnecessarily long.
Russian Roulette
A simple stopping criterion without russian roulette techniques introduces bias (the ETC drops off afterwards).
This is usually not a problem.
Do we want to implement russian roulette anyways?
Testing
Checklist
cuda_*andllvm_*variants. If you can't test this, please leave belowdocs/release-notes.rst