Implement IsAttachedToConstraint & Improve Fixed Constraints#270
Open
RaphaelIT7 wants to merge 1 commit intomisyltoad:mainfrom
Open
Implement IsAttachedToConstraint & Improve Fixed Constraints#270RaphaelIT7 wants to merge 1 commit intomisyltoad:mainfrom
RaphaelIT7 wants to merge 1 commit intomisyltoad:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[+] Implement
JoltPhysicsObject::IsAttachedToConstraint[+] Improved fixed constraints
This works by implementing a
m_bConstraintPinnedbool, which acts like the normalm_bPinnedbool but is only set/used specifically by fixed constraints (or in the future by others too).If an object is frozen, all bodies connected using a fixed constraint will have their
m_bConstraintPinnedand their layers will be updated, effectively acting as if::EnableMotion(false)was used.The ingame result (tested in gmod) is a perfect (or as good as it gets) fixed constraint, which acts far better than Jolt's normal fixed constraint.
The issue with Jolt's normal fixed constraints is - that they aren't perfectly fixed - they can still move, still rotate, which isn't that great.