Request BLE scan/location permissions from Bluetooth connect blocks#83
Open
RiyanshiTomar wants to merge 2 commits intomit-cml:masterfrom
Open
Request BLE scan/location permissions from Bluetooth connect blocks#83RiyanshiTomar wants to merge 2 commits intomit-cml:masterfrom
RiyanshiTomar wants to merge 2 commits intomit-cml:masterfrom
Conversation
…ssions-dialog-in-scan-method Request BLE scan/location permissions from Bluetooth connect blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved: #79
-> Update SUtil.requestPermissionsForConnecting to request BLUETOOTH_CONNECT and BLUETOOTH_SCAN on Android 12+ and fall back to BLUETOOTH + BLUETOOTH_ADMIN on older Android. (appinventor/components/src/com/google/appinventor/components/runtime/util/SUtil.java)
-> Also add ACCESS_FINE_LOCATION to the requested permissions when the app declares it and NoLocationNeeded() is false so the Nearby/location prompt will be triggered for compatibility with existing BLE projects.
-> Expanded the method Javadoc to explain the compatibility rationale for requesting scan/location-related permissions from Connect flows.
Description
-> Request BLUETOOTH_SCAN and ACCESS_FINE_LOCATION permissions from Connect blocks
-> Trigger system permission dialogs on fresh installs for better UX
-> Maintain backward compatibility with Android versions pre-12
-> Expanded Javadoc explaining permission request rationale
Please merge this pull request
Thankyou