add heigth and width to image for picture classification#84
Open
josmas wants to merge 1 commit intomit-cml:extension/personal-image-classifierfrom
Open
add heigth and width to image for picture classification#84josmas wants to merge 1 commit intomit-cml:extension/personal-image-classifierfrom
josmas wants to merge 1 commit intomit-cml:extension/personal-image-classifierfrom
Conversation
Member
Author
|
Not needed if #85 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General items:
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
Description
ClassifyImageData fails on Android because the width and height
might be0 if the webviewer is not laid out by the time the image is sent for classification. This makes the extension work reliably, at least when it comes to tfjs not handling 0 size images correctly.Fixes # .
Resolves # .