Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Hi @ewpatton, @SusanRatiLane I have implemented fixes for Issue #3660 (Chromebook connection reset) and Issue #3372 (Neo UI source export and label sync). I have verified the logic and ensured it follows the existing patterns in the codebase. Could you please take a look or suggest a reviewer for these Neo UI improvements? Thanks! |
josmas
left a comment
There was a problem hiding this comment.
Most of the changes are formatting so it is really difficult to see what you are trying to accomplish here.
bdc4c2b to
4030319
Compare
josmas
left a comment
There was a problem hiding this comment.
there are still formatting changes that are not necessary; also seems like some of the internationalised messages are being lost?
|
Thanks for flagging this — from the diff it appears that some i18n usage may be affected. |
4030319 to
ab8119a
Compare
|
Hi @josmas, Thank you for the feedback! I've addressed both concerns:
I've removed all unnecessary formatting changes from XmlConfig.java. The file now contains only one functional change (line 437): Changed adaptive icon background from #ffffff to #00ffffff to fix issue #2328 (white edges on adaptive icons).
No i18n messages are being lost. The changes switch from text-based to ID-based menu item identification. The MESSAGES constants are still used when creating menu items, so users still see translated text. This change only affects how we reference menu items internally for enable/disable operations, making it more robust. What This PR Fixes: Issue #3660 - Chromebook Connect menu reset behavior |
…s, adaptive icon (mit-cml#2328) - Fixed Chromebook Connect menu reset behavior - Replaced magic numbers with named constants (Ode.PROJECTS, Ode.DESIGNER) - Fixed adaptive icon white edges with transparent background - Added comprehensive documentation Fixes mit-cml#3660 Fixes mit-cml#2328
ab8119a to
38773e8
Compare
General items:
ant testspasses on my machine - Attempted but failed due to Java 25 vs Java 11 incompatibilityIf your code changes how something works on the device (i.e., it affects the companion):
ucr- N/A (UI-only changes)ucras the base - N/A (UI-only changes)Further, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
This PR fixes multiple Neo UI consistency issues:
1. Chromebook Connect Menu Reset (#3660)
Fixed the issue where Emulator and USB options would incorrectly appear on Chromebooks after disconnecting. Now properly manages Chromebook vs non-Chromebook connection states.
2. View State Constants
Replaced magic numbers (0, 1) with named constants (Ode.PROJECTS, Ode.DESIGNER) for better code readability.
3. Adaptive Icon White Edges (#2328)
Changed launcher background from opaque white (#ffffff) to transparent (#00ffffff), eliminating white edges on adaptive icons.
Files Changed:
TopToolbar.java- Chromebook menu logic + view constantsXmlConfig.java- Adaptive icon transparencydocs/NEO_UI_FIXES.md- Comprehensive documentationFixes #3660
Fixes #2328