Fix #3639: Rename "Update the Companion" to "Update the Companion for Emulator"#3751
Open
jaideepj2004 wants to merge 2 commits intomit-cml:masterfrom
Open
Fix #3639: Rename "Update the Companion" to "Update the Companion for Emulator"#3751jaideepj2004 wants to merge 2 commits intomit-cml:masterfrom
jaideepj2004 wants to merge 2 commits intomit-cml:masterfrom
Conversation
…ion for Emulator' - Updated OdeMessages.java to clarify menu item applies to emulator only - Updated Portuguese translation in OdeMessages_pt.properties - Updated description comments in 8 localization files (ca, es_ES, hy, ja, ko_KR, pl, tr, uk) This change reduces confusion for mobile device users who expect the menu item to update their phone/tablet companion app. The menu item now clearly indicates it only updates the Companion for the Android emulator.
Collaborator
|
Can one of the admins verify this patch? |
1 similar comment
Collaborator
|
Can one of the admins verify this patch? |
josmas
requested changes
Feb 3, 2026
Member
josmas
left a comment
josmas
left a comment
There was a problem hiding this comment.
Please add a check for running emulator
Addresses review feedback from @josmas on PR mit-cml#3751. Changes: - Added isEmulatorRunning() check in CompanionUpdateAction - Added native method in BlocklyPanel to check ReplState - Added error message companionUpdateNeedEmulator in OdeMessages - Prevents update attempt when emulator is not connected This ensures the 'Update the Companion for Emulator' menu item only functions when the emulator is actually running and connected, providing better user feedback and preventing errors.
Author
|
@josmas Thank you for the review! I've added the emulator running check as requested. Changes made:
Behavior: The check ensures that:
Please let me know if you'd like any adjustments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3639
This PR renames the "Update the Companion" menu item to "Update the Companion for Emulator" to reduce confusion for mobile device users who expect it to update their phone/tablet companion app.
Changes Made
OdeMessages.javawith clearer menu item text and descriptionOdeMessages_pt.propertiesTesting
Before and After
Before:
After:
Rationale
As noted by @bobparks in #3639, workshop users with mobile devices are confused by the current menu item text. They expect it to update their phone's companion app, but it actually only updates the companion for the Android emulator. This change makes the purpose explicit.
Files Modified
appinventor/appengine/src/com/google/appinventor/client/OdeMessages.javaappinventor/appengine/src/com/google/appinventor/client/OdeMessages_pt.propertiesChecklist