Open
Conversation
Change-Id: I5eceabcf4323b26fbdf0ce360d8f88ade689e067
jisqyv
reviewed
Feb 24, 2026
|
|
||
| UIGraphicsBeginImageContext(CGSize(width: width, height: height)) | ||
| image.draw(in: CGRect(x: 0, y: 0, width: width, height: height)) | ||
| UIGraphicsBeginImageContext(CGSize(width: width, height: width)) |
Member
Author
There was a problem hiding this comment.
Yes. In reality the variable should probably be renamed to size since the inputs are square.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I5eceabcf4323b26fbdf0ce360d8f88ade689e067
General items:
ant testspasses on my machineFor all other changes:
mastermasteras the baseWhat does this PR accomplish?
This PR fixes a bug in the ClassifyImageData block of PIC. Base64 encoding the image results in lines ending with "\r\n" (Windows) rather than the assumed "\n" (macOS/iOS/Unix), so I adjusted the logic to take that into account. I also made it so that images are centered vertically in the viewport rather than truncated at the bottom. I think this is more closely what people might expect given the target of any given photo is likely to be close to the center of the camera.