Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

If the process cannot be found, it is better to return an error. #42

Open
jgbooks wants to merge 8 commits into
base: master
Choose a base branch
from
Open

If the process cannot be found, it is better to return an error. #42

jgbooks wants to merge 8 commits into from

Conversation

@jgbooks
Copy link

@jgbooks jgbooks commented Jul 17, 2020

If the process cannot be found, it is better to return an error.

@cfergeau
Copy link

cfergeau commented Mar 8, 2021

This is an API breakage, dunno how bad the impact would be on go-ps users.
Windows and macOS would still return nil when the process is not found, so this change would make the API inconsistent on the various OSes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgbooks @cfergeau @0xsubi