Baseline implementation for QUEST (vector similarity and LLM query decomposition) #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README to clarify that results are not included.
tli2
reviewed
Dec 5, 2025
Collaborator
tli2
left a comment
tli2
left a comment
There was a problem hiding this comment.
Overall this is nice -- however, I think we should work a little bit on the organization of the codebase. Instead of having multiple top-level .py that is invoked from the command line, we should probably have one entry point per experiment and organize the rest more explicitly as a library.
| print(f"Warning: Skipping malformed line in {path}") | ||
| continue | ||
|
|
||
| def main(): |
Collaborator
There was a problem hiding this comment.
General nit: Maybe it's better to expose these functionalities as function calls rather than main().
| if line: | ||
| yield json.loads(line) | ||
|
|
||
| def retrieve(queries_path: str, output_path: str): |
Collaborator
There was a problem hiding this comment.
What's the difference between this and decompose/retrieve.py?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes and workflow are detailed in the README file here: https://github.com/mitdbg/Carnot/blob/baseline/baseline_quest/README.md.
Thank you!