Semantic group by 253 #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdr223
commented
Dec 3, 2025
Collaborator
Author
mdr223
left a comment
mdr223
left a comment
There was a problem hiding this comment.
Overall -- fantastic job!! You went above and beyond what I expected; including getting started with (1) using our Generator for LLM calls w/built-in cost / latency tracking and (2) marshaling those stats into a DataRecordSet to be returned by the __call__ method.
That alone knocked out like 50-70% of what I had planned for your next steps. I'll follow-up with those details in the same issue from before.
…d non-semantic groupbys
mdr223
commented
Jan 7, 2026
Collaborator
Author
mdr223
left a comment
mdr223
left a comment
There was a problem hiding this comment.
Looks great! I just left some minor comments which should only take ~15-30 mins to resolve. Once those changes are applied I will merge dev into this branch and we can begin to prepare for merging this into main!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.