-
-
Notifications
You must be signed in to change notification settings - Fork 128
fix: Storage safety, gateway stability, auth UX, canvas, deps (#21, #54, #55, #56, #59, #60, #61, #63, #64, #65, #66, #67) #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
a89e595
a94c515
448d679
1201009
0c94229
720d89d
5e8144f
0140474
67a3969
1f41fe7
5980af5
ecd552f
60852aa
3618c93
414dd17
33773de
6418a81
8409df6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- fullBackupContent rules for Android ≤11 --> | ||
| <full-backup-content> | ||
| <include domain="sharedpref" path="." /> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Android SharedPreferences usage (Kotlin/Java) =="
rg -n -C2 --type=kt --type=java \
'getSharedPreferences\(|EncryptedSharedPreferences|PreferenceManager\.getDefaultSharedPreferences' || true
echo
echo "== Dart persistence usage (shared_preferences / secure storage) =="
rg -n -C2 --type=dart \
'SharedPreferences\.getInstance|shared_preferences|flutter_secure_storage' || true
echo
echo "== Potentially sensitive key names in Dart code =="
rg -n -C2 --type=dart \
'(token|secret|password|api[_-]?key|auth)' flutter_app/lib || true
echo
echo "== Current backup XML resources =="
for f in $(fd 'backup_rules\.xml|data_extraction_rules\.xml' flutter_app/android/app/src/main/res/xml); do
echo "--- $f ---"
cat "$f"
doneRepository: mithun50/openclaw-termux Length of output: 28711 Exclude private keys and auth tokens from backup rules — they are currently exposed. Verification confirms this is a critical security issue. The app stores sensitive data in SharedPreferences that will be backed up:
The current rules ( 🤖 Prompt for AI Agents |
||
| </full-backup-content> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- dataExtractionRules for Android 12+ --> | ||
| <data-extraction-rules> | ||
| <cloud-backup> | ||
| <include domain="sharedpref" path="." /> | ||
| </cloud-backup> | ||
| <device-transfer> | ||
| <include domain="sharedpref" path="." /> | ||
| </device-transfer> | ||
| </data-extraction-rules> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <usb-device /> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Overly permissive USB device filter — Consider restricting to common USB-serial adapter vendor/product IDs (FTDI, CP210x, CH340, PL2303) or at minimum filtering by device class. For example: Prompt for AI agents |
||
| </resources> | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1:
isRunningis read cross-thread without@Volatile, so this visibility check may not work correctly.onDestroy()setsisRunning = falseon the main thread, but this worker thread may never see the update due to JMM caching, causing unintended sshd restarts after an intentional stop. Add@Volatileto theisRunningdeclaration in the companion object.Prompt for AI agents