Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.0.3. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.0.3) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.0.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:50">
P2: `@eslint/js` is still pinned to `^9.17.0` but should be updated to `^10.0.3` alongside ESLint 10. The v10 release updated `eslint:recommended` and added `eslint` as a peer dependency of `@eslint/js`, so leaving this at v9 creates a version mismatch.</violation>
<violation number="2" location="package.json:50">
P1: ESLint 10 drops support for Node.js 18, but the project's `engines` field still allows `>=18.0.0`. Users on Node.js 18.x will be unable to run `npm run lint`. Either update the `engines.node` field to `>=20.19.0` or keep ESLint at v9 until the minimum Node.js version is raised.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "devDependencies": { | ||
| "@eslint/js": "^9.17.0", | ||
| "eslint": "^9.17.0", | ||
| "eslint": "^10.0.3", |
There was a problem hiding this comment.
P1: ESLint 10 drops support for Node.js 18, but the project's engines field still allows >=18.0.0. Users on Node.js 18.x will be unable to run npm run lint. Either update the engines.node field to >=20.19.0 or keep ESLint at v9 until the minimum Node.js version is raised.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 50:
<comment>ESLint 10 drops support for Node.js 18, but the project's `engines` field still allows `>=18.0.0`. Users on Node.js 18.x will be unable to run `npm run lint`. Either update the `engines.node` field to `>=20.19.0` or keep ESLint at v9 until the minimum Node.js version is raised.</comment>
<file context>
@@ -47,7 +47,7 @@
"devDependencies": {
"@eslint/js": "^9.17.0",
- "eslint": "^9.17.0",
+ "eslint": "^10.0.3",
"globals": "^15.14.0"
}
</file context>
| @@ -47,7 +47,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
P2: @eslint/js is still pinned to ^9.17.0 but should be updated to ^10.0.3 alongside ESLint 10. The v10 release updated eslint:recommended and added eslint as a peer dependency of @eslint/js, so leaving this at v9 creates a version mismatch.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 50:
<comment>`@eslint/js` is still pinned to `^9.17.0` but should be updated to `^10.0.3` alongside ESLint 10. The v10 release updated `eslint:recommended` and added `eslint` as a peer dependency of `@eslint/js`, so leaving this at v9 creates a version mismatch.</comment>
<file context>
@@ -47,7 +47,7 @@
"devDependencies": {
"@eslint/js": "^9.17.0",
- "eslint": "^9.17.0",
+ "eslint": "^10.0.3",
"globals": "^15.14.0"
}
</file context>
Bumps eslint from 9.39.2 to 10.0.3.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
bfce7ea10.0.3d44ced8Build: changelog update for 10.0.3e511b58fix: update eslint (#20595)ef8fb92chore: package.json update for eslint-config-eslint releasee8f2104chore: updates for v9.39.4 release5cd1604refactor: simplify isCombiningCharacter helper (#20524)9fc31b0docs: Update README70ff1d0chore: eslint-config-eslint require Node^20.19.0 || ^22.13.0 || >=24(#20586)f4c9cf9fix: include variable name inno-useless-assignmentmessage (#20581)4efaa36docs: add info box foreslint-plugin-eslint-comments(#20570)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by cubic
Upgrade
eslintto 10.0.3 to pick up security fixes and latest rule updates. This also updates transitive ESLint tooling and raises the minimum Node version required.Dependencies
eslintto^10.0.3.minimatch@^10,espree@^11,eslint-scope@^9,ajv@6.14.0.@eslint/eslintrc,js-yaml,strip-json-comments) per ESLint v10 internals.Migration
^20.19.0 || ^22.13.0 || >=24(update local and CI runtimes).Written for commit e35cfe1. Summary will update on new commits.