Skip to content

Conversation

@mhils
Copy link
Member

@mhils mhils commented Dec 27, 2024

This should unbreak CI on main.

@mhils mhils marked this pull request as ready for review December 27, 2024 16:39
@mhils mhils enabled auto-merge (squash) December 27, 2024 16:39
@mhils mhils merged commit 0cd133f into main Dec 27, 2024
20 checks passed
@mhils mhils deleted the mhils-patch-1 branch December 27, 2024 16:43
@AgentConDier
Copy link

Just a heads up, according to my pip, the latest mitmproxy 11.0.2 requires mitmproxy_rs<0.11,>=0.10.7. That resolves to 0.10.7 which won't install on platforms without a pre-built wheel (Termux in this example) because this fix hasn't been applied yet and the build fails.

Requirement already satisfied: mitmproxy in /data/data/com.termux/files/usr/lib/python3.12/site-packages (11.0.0)
Collecting mitmproxy
  Using cached mitmproxy-11.0.2-py3-none-any.whl.metadata (9.2 kB)
[…]
Collecting mitmproxy_rs<0.11,>=0.10.7 (from mitmproxy)
  Using cached mitmproxy_rs-0.10.7.tar.gz (1.2 MB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [5 lines of output]
      💥 maturin failed
        Caused by: `project.version` field is required in pyproject.toml unless it is present in the `project.dynamic` list
      Error running maturin: Command '['maturin', 'pep517', 'write-dist-info', '--metadata-directory', '/data/data/com.termux/files/usr/tmp/pip-modern-metadata-ol5kghex', '--interpreter', '/data/data/com.termux/files/usr/bin/python3.12']' returned non-zero exit status 1.
      Checking for Rust toolchain....
      Running `maturin pep517 write-dist-info --metadata-directory /data/data/com.termux/files/usr/tmp/pip-modern-metadata-ol5kghex --interpreter /data/data/com.termux/files/usr/bin/python3.12`
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

When using a modified tarball with the line added, the wheel builds and installs without issue.

@mhils
Copy link
Member Author

mhils commented Dec 29, 2024

@AgentConDier: Thanks, I've filed PyO3/maturin#2417 upstream. We'll push a patch release if that takes time. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants