Add CSS and JS syntax highlighting #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR adds syntax highlighting support for CSS and JavaScript in addition to the existing XML and YAML highlighting functionality.
- Updated function signatures and language enums to incorporate "css" and "javascript".
- Added new modules and tests for CSS and JavaScript syntax highlighting.
- Adjusted dependency ordering in Cargo.toml and updated changelog accordingly.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| mitmproxy-rs/mitmproxy_rs/syntax_highlight.pyi | Extended language literal to include CSS and JavaScript. |
| mitmproxy-highlight/src/yaml.rs | Renamed functions to a consistent naming scheme and updated tests. |
| mitmproxy-highlight/src/xml.rs | Renamed functions to a consistent naming scheme and updated tests. |
| mitmproxy-highlight/src/lib.rs | Expanded Language enum and updated match logic to include new variants. |
| mitmproxy-highlight/src/javascript.rs | Added new module for JavaScript syntax highlighting with tests. |
| mitmproxy-highlight/src/css.rs | Added new module for CSS syntax highlighting with tests. |
| mitmproxy-highlight/src/common.rs | Renamed internal test function to reflect tag usage. |
| mitmproxy-highlight/Cargo.toml | Added new dependencies and reordered existing ones. |
| CHANGELOG.md | Documented changes for CSS and JS syntax highlighting. |
lups2000
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "css" and "javascript" syntax highlighting.