Fix TypeError when cls.__module__ is None #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
requested changes
Jan 29, 2025
Member
mhils
left a comment
mhils
left a comment
There was a problem hiding this comment.
I don't think changing the behavior of _safe_getattr is sensible as that is supposed to mirror getattr. Can we do an or "" at the callsite please?
iFreilicht
force-pushed
the
fix-typeerror-when-module-is-none
branch
from
8b029a5 to
627fbc4
Compare
Contributor
Author
|
Yeah I see what you mean. I was debating between the two solutions myself. Fixed! |
Trying to use `pdoc -o` instead of `pdoc` in my project caused a long
stacktrace with this error at the end:
File "/Users/feuh/.../.venv/lib/python3.12/site-packages/pdoc/doc.py", line 640, in _var_annotations
_safe_getattr(cls, "__module__", "") + "." + cls.__qualname__
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
This was caused by one class' `__module__` attribute being `None`.
I could not find the reason why that happens and why it happens only
when using `-o`, but this change ensures it won't happen again.
mhils
force-pushed
the
fix-typeerror-when-module-is-none
branch
from
2b3cb0a to
b4b1dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use
pdoc -oinstead ofpdocin my project caused a long stacktrace with this error at the end:This was caused by one class'
__module__attribute beingNone.I could not find the reason why that happens and why it happens only when using
-o, but this change ensures it won't be a problem again.