Fix Markup-returning functions' return type #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFreilicht
force-pushed
the
fix-Markup-return-types
branch
from
ae020a2 to
1632af4
Compare
Markup is a sub-class of string, so this wasn't strictly *wrong*, but it's more correct this way and clearer when extending these filters.
iFreilicht
force-pushed
the
fix-Markup-return-types
branch
from
1632af4 to
fc2342b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markup is a sub-class of str, so this wasn't strictly wrong, but it's more correct this way and clearer when extending these filters.