-
-
Notifications
You must be signed in to change notification settings - Fork 212
Process HTML <img> tags in addition to markdown image markup when embedding local images
#785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process HTML <img> tags in addition to markdown image markup when embedding local images
#785
Conversation
|
Also, not sure why |
mhils
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This looks good. Please 1) rebase onto main and 2) add a CHANGELOG entry.
The autofix.ci changes were because you updated uv.lock, which updated our dependencies, which updated the HTML generated by pdoc for snapshot tests. I've done the same in #788, so this PR should be clean now.
62d42ad to
776d932
Compare
Done |
mhils
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please keep the whitespace changes in CHANGELOG.md at bay? I don't mind the occasional fly-by change, but (some) whitespace in Markdown has semantic meaning.
776d932 to
a4dba5c
Compare
Sorry, fixed now. By the way, have you considered using explicit |
… when embedding local images
a4dba5c to
3c6e92e
Compare
Subjective preference for Markdown over HTML. I don't feel super strongly, but it's a Markdown document so using Markdown syntax is fine IMO. :) Thanks again for the PR! |
Extends #282 and #460.
Demo (copied from extended
testdata/demo_long.py):I am interested in this because there is no "official" way to specify image width and height in Markdown markup.
markdown2doesn't seem to recognize thesyntax supported by some other Markdown implementations.