Open
Conversation
new strings added by previous updates are now included in the english locale
new strings added by previous updates are now included in the rtl locale
new strings added by previous updates are now included in the fake2 locale
new strings added by previous updates are now included in the eo locale
added fr locale for french language
Member
|
Sorry @2018D I'm not familiar with how translations work. Is this something we should be merging into master? Is it ready for review? How can we test the PR? |
Author
|
Hello @pdpinch, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
(Required)
What's this PR do?
Update all language locale to reflect previous code change since 2017.
Added french localization.
How should this be manually tested?
Use edx-sga on a french language platform.
Where should the reviewer start?
(Optional)
Any background context you want to provide?
(Optional)
Screenshots (if appropriate)
(Optional)
What GIF best describes this PR or how it makes you feel?
(Optional)