fix: handle numbers-only username generation fails #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes https://github.com/mitodl/hq/issues/9423
Description (What does it do?)
When users register with numbers-only names (e.g.,
15418306) and their email local part is also numbers-only (e.g.,[email protected]), theusernameifyfunction fails with a ValueError. This is because TheUSERNAME_INVALID_CHAR_PATTERNconstant includes [\d] which removes all digits from usernames to comply with Open edX's requirement that usernames cannot be entirely numeric.This PR, instead of raising a ValueError when both name and email fail to produce a username, we now generate a random username as a fallback. This ensures users can still register successfully even with edge case inputs.
How can this be tested?
Additional Context
This is mostly a fallback strategy and the original issue would be resolved through validation checks within MITxOnline forms.