Conversation
45c331c to
7fb92e0
Compare
7fb92e0 to
6c10ba8
Compare
6c10ba8 to
5563cb6
Compare
| @@ -73,7 +73,7 @@ | |||
| "@typescript-eslint/eslint-plugin": "^6.1.0", | |||
| "@typescript-eslint/parser": "^6.1.0", | |||
| "css-loader": "^7.0.0", | |||
There was a problem hiding this comment.
Bug: The ESLint upgrade to v10 removes the --ext flag, but the eslint:check script still uses it. This will cause the linting command to fail.
Severity: CRITICAL
Suggested Fix
To fix this, migrate the ESLint configuration to the new flat config format (eslint.config.js) and remove the --ext flag. The recommended path is to adopt the new configuration system, as the --ext flag is no longer supported with the legacy configuration in ESLint v10.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: ol-jupyter-authoring/package.json#L75
Potential issue: The pull request upgrades ESLint to v10, which removes support for the
`--ext` command-line flag. The `eslint:check` script in `package.json` for both
`ol-jupyter-authoring` and `ol-themed-jupyter` still uses this flag. As a result,
running the linting command, such as `jlpm lint:check`, will immediately fail with an
"Invalid option '--ext'" error. This breaks a core part of the development workflow and
will likely cause CI/CD pipeline failures.
5563cb6 to
a86e798
Compare
| "@typescript-eslint/parser": "^6.1.0", | ||
| "css-loader": "^7.0.0", | ||
| "eslint": "^9.0.0", | ||
| "eslint": "^10.0.0", |
There was a problem hiding this comment.
Bug: The ESLint v10 upgrade breaks linting because the scripts use the now-removed --ext flag and the required eslint.config.js configuration file is missing.
Severity: CRITICAL
Suggested Fix
Migrate the ESLint configuration from the eslintConfig field in package.json to a new eslint.config.js file using the modern flat config format. Then, remove the obsolete --ext .ts,.tsx flag from the eslint:check script in package.json.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: ol-themed-jupyter/package.json#L68
Potential issue: The upgrade to ESLint v10 will cause linting commands like `jlpm
lint:check` to fail with a runtime error. This is because the lint scripts in
`package.json` for `ol-themed-jupyter` and `ol-jupyter-authoring` use the `--ext
.ts,.tsx` command-line flag, which was removed in ESLint v10. Additionally, the existing
ESLint configuration within the `eslintConfig` field of `package.json` is no longer
supported and will be ignored, as v10 requires a new `eslint.config.js` file. The
combination of the invalid flag and missing configuration file will break the linting
process, impacting local development workflows and CI/CD pipelines.
This PR contains the following updates:
^9.0.0→^10.0.0^9.0.0→^10.0.0Release Notes
eslint/eslint (eslint)
v10.0.0Compare Source
v9.39.2Compare Source
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.