Open
Conversation
|
@dtwalter approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package_tooltakes a feature_number and tries to convert it to 1 byte withfeature_number.to_bytes(1, "little")which will break for any feature numbers greater than 255 with the errorOverflowError: int too big to convert. The technical specification says the feature number is 32 bits long.To make it conform to the technical specifications but with minimal refactoring (the package number is expected to be 1 byte in several places), and since the only feature numbers that will be used are 1 and 2, the feature number is truncated to 8 bits during packaging