Draft
Conversation
added 30 commits
January 31, 2023 15:41
Anmol-Srivastava
requested changes
Mar 17, 2023
| import noise | ||
|
|
||
|
|
||
| def select_random_classes(series): |
Contributor
There was a problem hiding this comment.
This could use a docstring describing the function with a section for arguments and return value
| @@ -0,0 +1,589 @@ | |||
| import matplotlib.pyplot as plt | |||
Contributor
There was a problem hiding this comment.
A top-level docstring describing what this module is for in a short line or so would be helpful
| return [class_a, class_b] | ||
|
|
||
|
|
||
| class InjectionTesting: |
Contributor
There was a problem hiding this comment.
Same thing here, a docstring which can be modeled after the docstrings in any of the detectors e.g. KdqTreeBatch
|
|
||
| return [start_row, end_row] | ||
|
|
||
| def train_linear_model(self, x_cols=None, y_col=None, start=0, end=0.75): |
Contributor
There was a problem hiding this comment.
Docstring for summary, arguments, output
Contributor
|
It also looks like the GitHub checks are failing because of tests not passing / non-100% coverage and linting/security steps missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.