Simple Dockerfiles for both CPU and GPU#264
Open
tomasiser wants to merge 3 commits intomitsuba-renderer:masterfrom
Open
Simple Dockerfiles for both CPU and GPU#264tomasiser wants to merge 3 commits intomitsuba-renderer:masterfrom
tomasiser wants to merge 3 commits intomitsuba-renderer:masterfrom
Conversation
diiigle
suggested changes
Aug 26, 2020
Co-authored-by: Tobias Rittig <diiigle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The official Mitsuba 2 repository does not contain any Dockerfiles to be easily able to run Mitsuba 2 in a container. Because not everyone wants to run software on bare machines, and also to simplify reproducibility, @diiigle and I made two very simple Dockerfiles based on Ubuntu that support both CPU and GPU variants.
The images also directly support Python 3 and Jupyter to be able to easily run experiments.
The pull request contains two Dockerfiles and a separate README file.
Please let me know if this pull request is acceptable and/or if some changes to the original documentation should also be made. :)
Testing
No automated testing available
Checklist:
Please make sure to complete this checklist before requesting a review.
gpu_*andpacket_*variants. If you can't test this, please leave belowI have added tests that prove my fix is effective or that my feature works