Bugfixes (XML multi-object expand(), environment map classification)#86
Merged
Speierers merged 3 commits intomitsuba-renderer:masterfrom Apr 16, 2020
Merged
Bugfixes (XML multi-object expand(), environment map classification)#86Speierers merged 3 commits intomitsuba-renderer:masterfrom
Speierers merged 3 commits intomitsuba-renderer:masterfrom
Conversation
Member
|
Thanks @tszirr for those fixes, I will merge this PR. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix to XML multi-object expansion, environment map emitter classification, and a spectrum utility signature.
These fixes are included in the 'Compatibility & Sunsky' pull request (#85), but separated here, since they are topically unrelated, small, and in part significant.
Description of the environment map issue: Directional lights are also marked Infinite, therefore erroneously classified as environment emitter and conflicting with other environment maps.