Add ability to include additional CA certs for SSL requests#52
Open
evz wants to merge 5 commits intomitsuhiko:masterfrom
Open
Add ability to include additional CA certs for SSL requests#52evz wants to merge 5 commits intomitsuhiko:masterfrom
evz wants to merge 5 commits intomitsuhiko:masterfrom
Conversation
added 5 commits
June 6, 2013 13:25
… request." This reverts commit daa5b71.
|
There are few CA's missing from the list bundled by httplib2. It would be safe to replace the list with Mozilla accepted list, which is available in package certifi (line 197): self._client = OAuthClient(self._consumer)
self._client.ca_certs = certifi.where() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In working with an OAuth endpoint that used SSL, I discovered that the certifying authority’s certificate (Network Solutions in this case) was not included in the cacerts.txt file that ships with httplib2. This is a simple patch which adds a configuration parameter to the initial setup that allows passing in a path to a
pemfile that contains additional certificates.