Skip to content

[incr pipelines][DINO-284] enable sync by default for new schematized pipelines#2255

Merged
howardchen11 merged 7 commits intomainfrom
howardchen-dino-284-enable-sync-schematized-pipelines
Dec 5, 2025
Merged

[incr pipelines][DINO-284] enable sync by default for new schematized pipelines#2255
howardchen11 merged 7 commits intomainfrom
howardchen-dino-284-enable-sync-schematized-pipelines

Conversation

@howardchen11
Copy link
Contributor

@howardchen11 howardchen11 commented Dec 5, 2025

  1. enable sync by default for new schematized pipelines
  2. disable modifying sync

@howardchen11 howardchen11 requested a review from a team as a code owner December 5, 2025 06:01
@howardchen11 howardchen11 requested review from myronkaifung and removed request for a team December 5, 2025 06:01
@vercel
Copy link

vercel bot commented Dec 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Dec 5, 2025 7:32am

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

API Reference Preview

🚀 https://developer.mixpanel.com/v3.27-pr-2255/reference/overview
Last updated: 12/4/2025, 11:32:24 PM PT from 7d44420

@howardchen11 howardchen11 changed the title [incr pipelines][DINO-284] enable sync for new schematized pipelines [incr pipelines][DINO-284] enable sync by default for new schematized pipelines Dec 5, 2025
@mherrman
Copy link
Contributor

mherrman commented Dec 5, 2025

The changes look good but a few questions i had before we merged these changes.

  1. It sounds like the intention is to have all new schematized pipelines have sync enabled correct? What does this mean for schematized date-ranged pipelines that get created? Will they also automatically have sync enabled? I know previously we didnt really want them to have it enabled but dunno if it matters as much with the incremental system.
  2. Just a follow up for my knowledge, were json pipelines the same in that sync was already automatically enabled or was that not changing?

@howardchen11
Copy link
Contributor Author

howardchen11 commented Dec 5, 2025

The changes look good but a few questions i had before we merged these changes.

  1. It sounds like the intention is to have all new schematized pipelines have sync enabled correct? What does this mean for schematized date-ranged pipelines that get created? Will they also automatically have sync enabled? I know previously we didnt really want them to have it enabled but dunno if it matters as much with the incremental system.
  2. Just a follow up for my knowledge, were json pipelines the same in that sync was already automatically enabled or was that not changing?
  1. It sounds like the intention is to have all new schematized pipelines have sync enabled correct? Yes
  2. What does this mean for schematized date-ranged pipelines that get created? sync does not apply to date-range so it does not matter; the sync will be set to false in the codebase for date-range
  3. json pipelines follows the same rule: all new recurring & non-recurring will be sync (no non-sync recurring anymore)

@mherrman
Copy link
Contributor

mherrman commented Dec 5, 2025

awesome thanks! just approved

@howardchen11 howardchen11 merged commit f9e8723 into main Dec 5, 2025
11 checks passed
@howardchen11 howardchen11 deleted the howardchen-dino-284-enable-sync-schematized-pipelines branch December 5, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants